You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2017/07/17 04:58:51 UTC

[GitHub] storm pull request #2204: STORM-1280 port backtype.storm.daemon.logviewer to...

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2204#discussion_r127633153
  
    --- Diff: storm-buildtools/storm_checkstyle.xml ---
    @@ -46,6 +46,9 @@
      -->
     
     <module name = "Checker">
    +    <!-- Filter out Checkstyle warnings that have been suppressed with the @SuppressWarnings annotation -->
    --- End diff --
    
    I just add allowing SuppressWarnings annotation, since the test code contains long string constant. I didn't recognize that maven checkstyle doesn't check test codes, but it might be useful for specific situations anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---