You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/07/06 20:02:55 UTC

[GitHub] [tvm] junrushao1994 commented on a diff in pull request #12016: [MetaSchedule] Support ApplyHistoryBest Direct Dispatch

junrushao1994 commented on code in PR #12016:
URL: https://github.com/apache/tvm/pull/12016#discussion_r915210031


##########
python/tvm/meta_schedule/apply_history_best.py:
##########
@@ -85,8 +86,11 @@ def query(
             Target Info
         dispatched : Optional[List[IRModule]]
             A list of low-level IRs that the high-level IR could potentially dispatch to
-        f_take_tuning_record : Callable[[TuningRecord], None] = None
+        f_take_tuning_record : Optional[Callable[[TuningRecord], None]] = None
             A callback function that takes a tuning record and does something with it
+        f_direct_dispatch : Optional[Callable[[IRModule], Optional[Schedule]]] = None

Review Comment:
   Let's return `Optional[IRModule]` instead of `Optional[Schedule]`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org