[GitHub] [incubator-druid] gianm commented on a change in pull request #8905: Retrying with a backward compatible task type on unknown task type error in parallel indexing

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #8905: Retrying with a backward compatible task type on unknown task type error in parallel indexing
URL: https://github.com/apache/incubator-druid/pull/8905#discussion_r348229372
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/TaskMonitor.java
 ##########
 @@ -265,6 +263,22 @@ private void retry(String subTaskSpecId, MonitorEntry monitorEntry, TaskStatusPl
     }
   }
 
+  private T submitTask(SubTaskSpec<T> spec, int numAttempts)
+  {
+    T task = spec.newSubTask(numAttempts);
+    try {
+      indexingServiceClient.runTask(task);
 
 Review comment:
   Will this approach be able to retry immediately, or will it have to exhaust retries in the `indexingServiceClient` first? (The loop in DruidLeaderClient)
   
   Ideally, this detects a problem on the first submission, and doesn't need to exhaust retries before it moves on to trying the backwards-compatible type.
   
   Could you check it, if you haven't already?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org