You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Akos Kovacs (Code Review)" <ge...@cloudera.org> on 2020/05/05 13:50:05 UTC

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling 

Akos Kovacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15864


Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................

IMPALA-7833 Audit and fix string builtins for long string handling

Some string built-in functions could crash impalad,
in case the result was longer than 1 gig max size.
Added some overflow checks.

Testing:
* Added some backend tests to cover overflow check
* Ran core tests

Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
---
M be/src/exprs/string-functions-ir.cc
M testdata/workloads/functional-query/queries/QueryTest/large_strings.test
2 files changed, 52 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/15864/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 1
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5785/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 2
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 22:10:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5800/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 5
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 May 2020 06:28:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Akos Kovacs (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Tim Armstrong, Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15864

to look at the new patch set (#6).

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................

IMPALA-7833 Audit and fix string builtins for long string handling

Some string built-in functions could crash impalad,
in case the result was longer than 1 gig max size.
Added some overflow checks.
Overflow error messages modified not to hard code max size.

Testing:
* Added some backend tests to cover overflow check
* Ran core tests

Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
---
M be/src/exprs/aggregate-functions-ir.cc
M be/src/exprs/expr-test.cc
M be/src/exprs/string-functions-ir.cc
M testdata/workloads/functional-query/queries/QueryTest/large_strings.test
4 files changed, 104 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/15864/6
-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 6
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6022/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 5
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 May 2020 07:28:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15864/3/be/src/exprs/string-functions-ir.cc
File be/src/exprs/string-functions-ir.cc:

http://gerrit.cloudera.org:8080/#/c/15864/3/be/src/exprs/string-functions-ir.cc@89
PS3, Line 89: 1 GB
Instead of hard-coding it in the error message you could use pretty-printer with StringVal::MAX_LENGTH and TUnit::BYTES:

https://github.com/apache/impala/blob/master/be/src/util/pretty-printer.h#L53



-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 3
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 09:21:02 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 10:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5818/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 10
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 11:48:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 10:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6050/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 10
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 08:45:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 11:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5822/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 11
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 16:42:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................

IMPALA-7833 Audit and fix string builtins for long string handling

Some string built-in functions could crash impalad,
in case the result was longer than 1 gig max size.
Added some overflow checks.
Overflow error messages modified not to hard code max size.

Testing:
* Added some backend tests to cover overflow check
* Ran core tests

Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Reviewed-on: http://gerrit.cloudera.org:8080/15864
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exprs/aggregate-functions-ir.cc
M be/src/exprs/expr-test.cc
M be/src/exprs/string-functions-ir.cc
M testdata/workloads/functional-query/queries/QueryTest/large_strings.test
4 files changed, 109 insertions(+), 27 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 12
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5979/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 2
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 May 2020 15:36:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 11: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 11
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 16:42:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Akos Kovacs (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15864

to look at the new patch set (#10).

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................

IMPALA-7833 Audit and fix string builtins for long string handling

Some string built-in functions could crash impalad,
in case the result was longer than 1 gig max size.
Added some overflow checks.
Overflow error messages modified not to hard code max size.

Testing:
* Added some backend tests to cover overflow check
* Ran core tests

Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
---
M be/src/exprs/aggregate-functions-ir.cc
M be/src/exprs/expr-test.cc
M be/src/exprs/string-functions-ir.cc
M testdata/workloads/functional-query/queries/QueryTest/large_strings.test
4 files changed, 109 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/15864/10
-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 10
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15864/2/testdata/workloads/functional-query/queries/QueryTest/large_strings.test
File testdata/workloads/functional-query/queries/QueryTest/large_strings.test:

http://gerrit.cloudera.org:8080/#/c/15864/2/testdata/workloads/functional-query/queries/QueryTest/large_strings.test@247
PS2, Line 247: repeat()
It would be nicer to mention the name of the function that resulted in error in the message.



-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 2
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 May 2020 16:55:53 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 5:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/15864/5/be/src/exprs/aggregate-functions-ir.cc
File be/src/exprs/aggregate-functions-ir.cc:

http://gerrit.cloudera.org:8080/#/c/15864/5/be/src/exprs/aggregate-functions-ir.cc@759
PS5, Line 759:         + PrettyPrinter::Print(StringVal::MAX_LENGTH, TUnit::BYTES) + " character data.").c_str());
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/15864/5/be/src/exprs/aggregate-functions-ir.cc@791
PS5, Line 791:         + PrettyPrinter::Print(StringVal::MAX_LENGTH, TUnit::BYTES) + " character data.").c_str());
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/15864/5/be/src/exprs/string-functions-ir.cc
File be/src/exprs/string-functions-ir.cc:

http://gerrit.cloudera.org:8080/#/c/15864/5/be/src/exprs/string-functions-ir.cc@90
PS5, Line 90:         + PrettyPrinter::Print(StringVal::MAX_LENGTH, TUnit::BYTES) + " character data.").c_str());
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/15864/5/be/src/exprs/string-functions-ir.cc@104
PS5, Line 104:     context->SetError(("Number of repeats in repeat() call is larger than allowed limit of "
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/15864/5/be/src/exprs/string-functions-ir.cc@105
PS5, Line 105:         + PrettyPrinter::Print(StringVal::MAX_LENGTH, TUnit::BYTES) + " character data.").c_str());
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/15864/5/be/src/exprs/string-functions-ir.cc@114
PS5, Line 114:         + PrettyPrinter::Print(StringVal::MAX_LENGTH, TUnit::BYTES) + " character data.").c_str());
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/15864/5/be/src/exprs/string-functions-ir.cc@136
PS5, Line 136:         + PrettyPrinter::Print(StringVal::MAX_LENGTH, TUnit::BYTES) + " character data.").c_str());
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/15864/5/be/src/exprs/string-functions-ir.cc@168
PS5, Line 168:         + PrettyPrinter::Print(StringVal::MAX_LENGTH, TUnit::BYTES) + " character data.").c_str());
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/15864/5/be/src/exprs/string-functions-ir.cc@892
PS5, Line 892:         + PrettyPrinter::Print(StringVal::MAX_LENGTH, TUnit::BYTES) + " character data.").c_str());
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/15864/5/be/src/exprs/string-functions-ir.cc@939
PS5, Line 939:         + PrettyPrinter::Print(StringVal::MAX_LENGTH, TUnit::BYTES) + " character data.").c_str());
line too long (99 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 5
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 May 2020 06:28:57 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5752/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 1
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 May 2020 13:53:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 3
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 12:05:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 11: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 11
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 22:01:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 10: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 10
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 16:42:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 6: Code-Review+1

(2 comments)

Found a couple of nits, but other than that LGTM.

http://gerrit.cloudera.org:8080/#/c/15864/6/be/src/exprs/aggregate-functions-ir.cc
File be/src/exprs/aggregate-functions-ir.cc:

http://gerrit.cloudera.org:8080/#/c/15864/6/be/src/exprs/aggregate-functions-ir.cc@758
PS6, Line 758: "Concatenated string length larger than allowed limit of "
             :         + PrettyPrinter::Print(StringVal::MAX_LENGTH, TUnit::BYTES)
             :         + " character data.").c_str()
> nit: Impala's convention is to use the Substitute() function from "gutil/st
Also, the format string could be stored in a global constant, so you wouldn't  repeat it multiple times.


http://gerrit.cloudera.org:8080/#/c/15864/6/be/src/exprs/string-functions-ir.cc
File be/src/exprs/string-functions-ir.cc:

http://gerrit.cloudera.org:8080/#/c/15864/6/be/src/exprs/string-functions-ir.cc@172
PS6, Line 172: "rpad() result is larger than allowed limit of "
nit: you could have a global format string like:

"$0 result is larger than allowed limit of $1 character data."

and you'd just pass 'space()/repeat()/lpad()/rpad()' and the limit to Substitute().



-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 6
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 May 2020 14:23:06 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 2:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5785/


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 2
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 03:05:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 2:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5780/


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 2
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 20:01:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5804/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 6
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 May 2020 13:27:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5762/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 2
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 May 2020 14:54:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5780/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 2
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 14:45:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 10: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 10
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 16:31:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 6: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5804/


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 6
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 May 2020 14:05:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5762/


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 2
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 May 2020 20:08:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5752/


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 1
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 May 2020 19:07:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5789/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 3
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 06:51:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 6:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/6023/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 6
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 May 2020 13:53:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Akos Kovacs (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15864

to look at the new patch set (#2).

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................

IMPALA-7833 Audit and fix string builtins for long string handling

Some string built-in functions could crash impalad,
in case the result was longer than 1 gig max size.
Added some overflow checks.

Testing:
* Added some backend tests to cover overflow check
* Ran core tests

Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
---
M be/src/exprs/string-functions-ir.cc
M testdata/workloads/functional-query/queries/QueryTest/large_strings.test
2 files changed, 67 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/15864/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 2
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15864/6/be/src/exprs/aggregate-functions-ir.cc
File be/src/exprs/aggregate-functions-ir.cc:

http://gerrit.cloudera.org:8080/#/c/15864/6/be/src/exprs/aggregate-functions-ir.cc@758
PS6, Line 758: "Concatenated string length larger than allowed limit of "
             :         + PrettyPrinter::Print(StringVal::MAX_LENGTH, TUnit::BYTES)
             :         + " character data.").c_str()
nit: Impala's convention is to use the Substitute() function from "gutil/strings/substitute.h"

E.g.:

  ctx->SetError(Substitute(
      "Concatenated string length larger than allowed limit of $0 character data.",
      PrettyPrinter::Print(StringVal::MAX_LENGTH, TUnit::BYTES)).c_str())


http://gerrit.cloudera.org:8080/#/c/15864/6/be/src/exprs/string-functions-ir.cc
File be/src/exprs/string-functions-ir.cc:

http://gerrit.cloudera.org:8080/#/c/15864/6/be/src/exprs/string-functions-ir.cc@106
PS6, Line 106: +
The clang-tidy job failed on this addition operator.

You can separate string literals with white spaces in C++, the compiler will concatenate them.

E.g.:
  cout << "Hello" "World"; // or
  cout << "Hello"
          "World";

Also, don't forget to use Substitute() instead.



-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 6
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 May 2020 14:14:48 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 6:

Thanks for fixing this. I don't plan to review so will remove myself as a reviewer.


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 6
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 01:48:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5959/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 1
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 May 2020 14:35:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Akos Kovacs (Code Review)" <ge...@cloudera.org>.
Akos Kovacs has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................

IMPALA-7833 Audit and fix string builtins for long string handling

Some string built-in functions could crash impalad,
in case the result was longer than 1 gig max size.
Added some overflow checks.
Overflow error messages modified not to hard code max size.

Testing:
* Added some backend tests to cover overflow check
* Ran core tests

Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
---
M be/src/exprs/aggregate-functions-ir.cc
M be/src/exprs/expr-test.cc
M be/src/exprs/string-functions-ir.cc
M testdata/workloads/functional-query/queries/QueryTest/large_strings.test
4 files changed, 94 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/15864/5
-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 5
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-7833 Audit and fix string builtins for long string handling

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )

Change subject: IMPALA-7833 Audit and fix string builtins for long string handling
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Gerrit-Change-Number: 15864
Gerrit-PatchSet: 5
Gerrit-Owner: Akos Kovacs <ak...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 May 2020 11:53:36 +0000
Gerrit-HasComments: No