You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/29 00:57:35 UTC
[GitHub] [pulsar] zhanghaou opened a new pull request #7091: [Issue 7049][WebSokcet] Make WebSocketService.MaxTextFrameSize configurable
zhanghaou opened a new pull request #7091:
URL: https://github.com/apache/pulsar/pull/7091
**Motivation**
fix [https://github.com/apache/pulsar/issues/7049](https://github.com/apache/pulsar/issues/7049)
Make WebSocketService.MaxTextFrameSize configurable.
**Modifications**
Add config of webSocketMaxTextFrameSize in websocket.conf, standalone.conf, broker.conf, and the default value is 1024*1024byte.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on pull request #7091: [Issue 7049][WebSokcet] Make WebSocketService.MaxTextFrameSize configurable
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on pull request #7091:
URL: https://github.com/apache/pulsar/pull/7091#issuecomment-635714306
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on pull request #7091: [Issue 7049][WebSocket] Make WebSocketService.MaxTextFrameSize configurable
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on pull request #7091:
URL: https://github.com/apache/pulsar/pull/7091#issuecomment-638099678
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #7091: [Issue 7049][WebSocket] Make WebSocketService.MaxTextFrameSize configurable
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #7091:
URL: https://github.com/apache/pulsar/pull/7091#issuecomment-636310454
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on pull request #7091: [Issue 7049][WebSocket] Make WebSocketService.MaxTextFrameSize configurable
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on pull request #7091:
URL: https://github.com/apache/pulsar/pull/7091#issuecomment-636784758
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on a change in pull request #7091: [Issue 7049][WebSokcet] Make WebSocketService.MaxTextFrameSize configurable
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on a change in pull request #7091:
URL: https://github.com/apache/pulsar/pull/7091#discussion_r432247182
##########
File path: pulsar-websocket/src/main/java/org/apache/pulsar/websocket/service/WebSocketProxyConfiguration.java
##########
@@ -66,6 +66,8 @@
private Optional<Integer> webServicePortTls = Optional.empty();
// Hostname or IP address the service binds on, default is 0.0.0.0.
private String bindAddress;
+ // The maximum size of a text message during parsing in WebSocket proxy
+ private int webSocketMaxTextFrameSize = 1024 * 1024;
Review comment:
The default value is the origial value in hard code, so I keep the same with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on pull request #7091: [Issue 7049][WebSokcet] Make WebSocketService.MaxTextFrameSize configurable
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on pull request #7091:
URL: https://github.com/apache/pulsar/pull/7091#issuecomment-635731762
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou closed pull request #7091: [Issue 7049][WebSocket] Make WebSocketService.MaxTextFrameSize configurable
Posted by GitBox <gi...@apache.org>.
zhanghaou closed pull request #7091:
URL: https://github.com/apache/pulsar/pull/7091
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on pull request #7091: [Issue 7049][WebSokcet] Make WebSocketService.MaxTextFrameSize configurable
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on pull request #7091:
URL: https://github.com/apache/pulsar/pull/7091#issuecomment-635769276
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on pull request #7091: [Issue 7049][WebSokcet] Make WebSocketService.MaxTextFrameSize configurable
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on pull request #7091:
URL: https://github.com/apache/pulsar/pull/7091#issuecomment-635749082
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on pull request #7091: [Issue 7049][WebSocket] Make WebSocketService.MaxTextFrameSize configurable
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on pull request #7091:
URL: https://github.com/apache/pulsar/pull/7091#issuecomment-635813272
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #7091: [Issue 7049][WebSokcet] Make WebSocketService.MaxTextFrameSize configurable
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #7091:
URL: https://github.com/apache/pulsar/pull/7091#discussion_r432218399
##########
File path: pulsar-websocket/src/main/java/org/apache/pulsar/websocket/service/WebSocketProxyConfiguration.java
##########
@@ -66,6 +66,8 @@
private Optional<Integer> webServicePortTls = Optional.empty();
// Hostname or IP address the service binds on, default is 0.0.0.0.
private String bindAddress;
+ // The maximum size of a text message during parsing in WebSocket proxy
+ private int webSocketMaxTextFrameSize = 1024 * 1024;
Review comment:
It's better to use 5MB as default value since the max message size of the broker is 5MB.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou removed a comment on pull request #7091: [Issue 7049][WebSokcet] Make WebSocketService.MaxTextFrameSize configurable
Posted by GitBox <gi...@apache.org>.
zhanghaou removed a comment on pull request #7091:
URL: https://github.com/apache/pulsar/pull/7091#issuecomment-635714306
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org