You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2021/11/16 15:49:00 UTC

[jira] [Comment Edited] (CASSANDRA-17141) internode_send_buff_size_in_bytes and internode_recv_buff_size_in_bytes from cassandra.yaml

    [ https://issues.apache.org/jira/browse/CASSANDRA-17141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444269#comment-17444269 ] 

Ekaterina Dimitrova edited comment on CASSANDRA-17141 at 11/16/21, 3:48 PM:
----------------------------------------------------------------------------

[~dcapwell] :
||[Patch 4.0|https://github.com/ekaterinadimitrova2/cassandra/commit/304683bc86b90c20f414c80d999c958116556b1b]|[CI J8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1199/workflows/a3f3cb0f-d341-4f01-986e-ead713fd7587/jobs/7168]|[CI J11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1199/workflows/5a5f5ec1-31f9-4af4-9ad2-d80c1e54674c]|
||[Patch trunk|https://github.com/apache/cassandra/commit/3dc31ccca771fc1adfc01e3feda8fffb425162e7]|[CI J8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1200/workflows/cfd02666-56aa-4081-ad7a-09c463978d89]|[CI J11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1200/workflows/70f9725d-fc27-4e8c-b6ca-39319cb68e6a]|

There are only a few failures - two failures with java 8 which are the well known bootstrap tests and the python upgrade tests for which we also have a ticket already. 

*4.0 failures:*

_readWriteDuringBootstrapTest_ - CASSANDRA-17139

_bootstrapTest_ - CASSANDRA-17076

_Python upgrade tests_ - CASSANDRA-17086, CASSANDRA-17140, CASSANDRA-17080

 

*trunk failures:*

_TestHintedHandoff#test_hintedhandoff_window_ - CASSANDRA-17144
_testWithoutStreamingEntireSSTablesWithCompression_ - fix for this one was just committed when I pushed the patch

 


was (Author: e.dimitrova):
[~dcapwell] :
||[Patch 4.0|https://github.com/ekaterinadimitrova2/cassandra/commit/304683bc86b90c20f414c80d999c958116556b1b]|[CI J8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1199/workflows/a3f3cb0f-d341-4f01-986e-ead713fd7587/jobs/7168]|[CI J11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1199/workflows/5a5f5ec1-31f9-4af4-9ad2-d80c1e54674c]|
||[Patch trunk|https://github.com/apache/cassandra/commit/3dc31ccca771fc1adfc01e3feda8fffb425162e7]|[CI J8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1200/workflows/cfd02666-56aa-4081-ad7a-09c463978d89]|[CI J11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1200/workflows/70f9725d-fc27-4e8c-b6ca-39319cb68e6a]|

There are only a few failures - two failures with java 8 which are the well known bootstrap tests and the python upgrade tests for which we also have a ticket already. 

4.0 failures:

readWriteDuringBootstrapTest - CASSANDRA-17139

bootstrapTest - CASSANDRA17076

Python upgrade tests - CASSANDRA-17086, CASSANDRA-17140, CASSANDRA-17080

 

trunk failures:

TestHintedHandoff#test_hintedhandoff_window - CASSANDRA-17144
testWithoutStreamingEntireSSTablesWithCompression 
- this one was just committed when I pushed the patch

 

> internode_send_buff_size_in_bytes and internode_recv_buff_size_in_bytes from cassandra.yaml 
> --------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17141
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17141
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Build
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.0.x, 4.x
>
>
> While working on CASSANDRA-17132 I found that in 4.0 _internode_send_buff_size_in_bytes_ and _internode_recv_buff_size_in_bytes_ were renamed to 
> _internode_socket_send_buffer_size_in_bytes_ and _internode_socket_receive_buffer_size_in_bytes_
> but only internally, not in cassandra.yaml. In cassandra.yaml we still have the old names. 
> Options I see:
>  - we decide that there is difference to be acknowledged so we just rename and announce the new parameters in NEWS.txt
>  - it is confirmed that just a rename was needed. Then do we want to add backward compatibility so that anyone who is still looking to start upgrade from 3 or 3.11 can directly go smoothly to 4.0.2 without breaking change? 
> CC [~benedict] , [~ifesdjeen] and [~aleksey] for your opinion what will be the right way to handle this issue.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org