You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2017/01/10 02:37:29 UTC
Review Request 55367: Improve "Install Wizard step 1" after new
guidelines
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55367/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku Sako.
Bugs: AMBARI-19432
https://issues.apache.org/jira/browse/AMBARI-19432
Repository: ambari
Description
-------
Should do the following adjustments to integrate with the new style guidelines:
As for the contents inside of the white panel:
1. Make tabs in a horizontal view.
2. Select stack button changed from blue to white.
3. Repositories should be the title of the following section, so move the radio buttons under that.
4. Make two radio buttons in horizontal view.
Diffs
-----
ambari-web/app/messages.js 0c3e10a
ambari-web/app/styles/wizard.less bc228c1
ambari-web/app/templates/wizard/step1.hbs 3b85895
Diff: https://reviews.apache.org/r/55367/diff/
Testing
-------
20205 passing (19s)
153 pending
Thanks,
Xi Wang
Re: Review Request 55367: Improve "Install Wizard step 1" after new
guidelines
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55367/#review161106
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Jan. 10, 2017, 2:37 a.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55367/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2017, 2:37 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku Sako.
>
>
> Bugs: AMBARI-19432
> https://issues.apache.org/jira/browse/AMBARI-19432
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Should do the following adjustments to integrate with the new style guidelines:
>
> As for the contents inside of the white panel:
> 1. Make tabs in a horizontal view.
> 2. Select stack button changed from blue to white.
> 3. Repositories should be the title of the following section, so move the radio buttons under that.
> 4. Make two radio buttons in horizontal view.
>
>
> Diffs
> -----
>
> ambari-web/app/messages.js 0c3e10a
> ambari-web/app/styles/wizard.less bc228c1
> ambari-web/app/templates/wizard/step1.hbs 3b85895
>
> Diff: https://reviews.apache.org/r/55367/diff/
>
>
> Testing
> -------
>
> 20205 passing (19s)
> 153 pending
>
>
> Thanks,
>
> Xi Wang
>
>
Re: Review Request 55367: Improve "Install Wizard step 1" after new
guidelines
Posted by Vivek Ratnavel Subramanian <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55367/#review161104
-----------------------------------------------------------
Ship it!
Ship It!
- Vivek Ratnavel Subramanian
On Jan. 10, 2017, 2:37 a.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55367/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2017, 2:37 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku Sako.
>
>
> Bugs: AMBARI-19432
> https://issues.apache.org/jira/browse/AMBARI-19432
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Should do the following adjustments to integrate with the new style guidelines:
>
> As for the contents inside of the white panel:
> 1. Make tabs in a horizontal view.
> 2. Select stack button changed from blue to white.
> 3. Repositories should be the title of the following section, so move the radio buttons under that.
> 4. Make two radio buttons in horizontal view.
>
>
> Diffs
> -----
>
> ambari-web/app/messages.js 0c3e10a
> ambari-web/app/styles/wizard.less bc228c1
> ambari-web/app/templates/wizard/step1.hbs 3b85895
>
> Diff: https://reviews.apache.org/r/55367/diff/
>
>
> Testing
> -------
>
> 20205 passing (19s)
> 153 pending
>
>
> Thanks,
>
> Xi Wang
>
>