You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/08/19 12:28:37 UTC

Review Request 37609: Change the default of topology.max.spout.pending from null to 1000 for Storm to prevent failures for Spout

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37609/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-12815
    https://issues.apache.org/jira/browse/AMBARI-12815


Repository: ambari


Description
-------

PROBLEM: The deployed kafkaspout showed "failures" in the Storm UI, however there were no exceptions. The latency was high. Currently, topology.max.spout.pending is set to null via ambari and if the topology does not override it, it will not be set.
At this point this can be set for kafkaspout configuration object in the topology code.


Diffs
-----

  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml b1cf129 
  ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/STORM/configuration/storm-site.xml b02d23a 
  ambari-server/src/test/python/stacks/2.1/configs/secured-storm-start.json.orig 118520d 

Diff: https://reviews.apache.org/r/37609/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 37609: Change the default of topology.max.spout.pending from null to 1000 for Storm to prevent failures for Spout

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37609/#review95844
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Сер. 19, 2015, 10:28 до полудня, Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37609/
> -----------------------------------------------------------
> 
> (Updated Сер. 19, 2015, 10:28 до полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-12815
>     https://issues.apache.org/jira/browse/AMBARI-12815
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> PROBLEM: The deployed kafkaspout showed "failures" in the Storm UI, however there were no exceptions. The latency was high. Currently, topology.max.spout.pending is set to null via ambari and if the topology does not override it, it will not be set.
> At this point this can be set for kafkaspout configuration object in the topology code.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml b1cf129 
>   ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/STORM/configuration/storm-site.xml b02d23a 
>   ambari-server/src/test/python/stacks/2.1/configs/secured-storm-start.json.orig 118520d 
> 
> Diff: https://reviews.apache.org/r/37609/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>