You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2012/02/08 03:37:01 UTC
Review Request: Flume-956 Config File Template
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3786/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
A simple config file template which uses a MemoryChannel, LoggerSink and SequenceGeneratorSource.
This addresses bug FLUME-956.
https://issues.apache.org/jira/browse/FLUME-956
Diffs
-----
conf/flume-conf.properties.template PRE-CREATION
Diff: https://reviews.apache.org/r/3786/diff
Testing
-------
None
Thanks,
Hari
Re: Review Request: Flume-956 Config File Template
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3786/#review4895
-----------------------------------------------------------
Ship it!
+1
- Arvind
On 2012-02-08 03:39:53, Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3786/
> -----------------------------------------------------------
>
> (Updated 2012-02-08 03:39:53)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> A simple config file template which uses a MemoryChannel, LoggerSink and SequenceGeneratorSource.
>
>
> This addresses bug FLUME-956.
> https://issues.apache.org/jira/browse/FLUME-956
>
>
> Diffs
> -----
>
> conf/flume-conf.properties.template PRE-CREATION
>
> Diff: https://reviews.apache.org/r/3786/diff
>
>
> Testing
> -------
>
> None
>
>
> Thanks,
>
> Hari
>
>
Re: Review Request: Flume-956 Config File Template
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3786/
-----------------------------------------------------------
(Updated 2012-02-08 03:39:53.329648)
Review request for Flume.
Changes
-------
Added license header.
Summary
-------
A simple config file template which uses a MemoryChannel, LoggerSink and SequenceGeneratorSource.
This addresses bug FLUME-956.
https://issues.apache.org/jira/browse/FLUME-956
Diffs (updated)
-----
conf/flume-conf.properties.template PRE-CREATION
Diff: https://reviews.apache.org/r/3786/diff
Testing
-------
None
Thanks,
Hari
Re: Review Request: Flume-956 Config File Template
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3786/
-----------------------------------------------------------
(Updated 2012-02-08 03:06:36.093906)
Review request for Flume.
Changes
-------
Removed trailing spaces
Summary
-------
A simple config file template which uses a MemoryChannel, LoggerSink and SequenceGeneratorSource.
This addresses bug FLUME-956.
https://issues.apache.org/jira/browse/FLUME-956
Diffs (updated)
-----
conf/flume-conf.properties.template PRE-CREATION
Diff: https://reviews.apache.org/r/3786/diff
Testing
-------
None
Thanks,
Hari
Re: Review Request: Flume-956 Config File Template
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3786/
-----------------------------------------------------------
(Updated 2012-02-08 03:05:30.984274)
Review request for Flume.
Changes
-------
Incorporated Arvind's feedback.
Summary
-------
A simple config file template which uses a MemoryChannel, LoggerSink and SequenceGeneratorSource.
This addresses bug FLUME-956.
https://issues.apache.org/jira/browse/FLUME-956
Diffs (updated)
-----
conf/flume-conf.properties.template PRE-CREATION
Diff: https://reviews.apache.org/r/3786/diff
Testing
-------
None
Thanks,
Hari
Re: Review Request: Flume-956 Config File Template
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3786/#review4894
-----------------------------------------------------------
Changes look good Hari. Some feedback:
1. If a sink does not have a channel configured, it will be discarded. You can configure the channel by using the following entry for sink configuration.
foo.sinks.loggerSink.channel = memoryChannel
2. Please add a comment on top that this configuration is applicable to an agent named "foo".
conf/flume-conf.properties.template
<https://reviews.apache.org/r/3786/#comment10793>
Typo: chances should be channels.
conf/flume-conf.properties.template
<https://reviews.apache.org/r/3786/#comment10791>
Built in source, use short type-name: "seq".
conf/flume-conf.properties.template
<https://reviews.apache.org/r/3786/#comment10790>
Built in sink, so use short type-name: "logger".
conf/flume-conf.properties.template
<https://reviews.apache.org/r/3786/#comment10792>
Built in channel, so use short type name: "memory"
- Arvind
On 2012-02-08 02:37:01, Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3786/
> -----------------------------------------------------------
>
> (Updated 2012-02-08 02:37:01)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> A simple config file template which uses a MemoryChannel, LoggerSink and SequenceGeneratorSource.
>
>
> This addresses bug FLUME-956.
> https://issues.apache.org/jira/browse/FLUME-956
>
>
> Diffs
> -----
>
> conf/flume-conf.properties.template PRE-CREATION
>
> Diff: https://reviews.apache.org/r/3786/diff
>
>
> Testing
> -------
>
> None
>
>
> Thanks,
>
> Hari
>
>