You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Jason van Zyl <jv...@sonatype.com> on 2009/03/17 16:23:07 UTC
Re: svn commit: r755199 - /maven/components/branches/maven-2.1.0-RC/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java
Why are you changing core code in the RC branch after we have started
the RC cycle?
Can we please leave the code alone in RCs and use the 2.1.x branch for
any non-regression related changes.
On 17-Mar-09, at 4:39 AM, brett@apache.org wrote:
> Author: brett
> Date: Tue Mar 17 11:39:18 2009
> New Revision: 755199
>
> URL: http://svn.apache.org/viewvc?rev=755199&view=rev
> Log:
> [MNG-4091] remove the listener for effeciency
>
> Modified:
> maven/components/branches/maven-2.1.0-RC/maven-core/src/main/java/
> org/apache/maven/plugin/DefaultPluginManager.java
>
> Modified: maven/components/branches/maven-2.1.0-RC/maven-core/src/
> main/java/org/apache/maven/plugin/DefaultPluginManager.java
> URL: http://svn.apache.org/viewvc/maven/components/branches/maven-2.1.0-RC/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java?rev=755199&r1=755198&r2=755199&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- maven/components/branches/maven-2.1.0-RC/maven-core/src/main/
> java/org/apache/maven/plugin/DefaultPluginManager.java (original)
> +++ maven/components/branches/maven-2.1.0-RC/maven-core/src/main/
> java/org/apache/maven/plugin/DefaultPluginManager.java Tue Mar 17
> 11:39:18 2009
> @@ -306,6 +306,10 @@
>
> Collections.EMPTY_MAP,
>
> Arrays.asList( new ComponentDiscoveryListener[] { validator,
> pluginCollector } ) );
>
> + // remove listeners for efficiency since they are only
> needed for the initial stage and
> + // should not be applied to the plugin's dependencies
> + child.removeComponentDiscoveryListener( validator );
> +
> if ( validator.hasErrors() )
> {
> String msg = "Plugin '" + key + "' has an invalid
> descriptor:";
>
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
----------------------------------------------------------
believe nothing, no matter where you read it,
or who has said it,
not even if i have said it,
unless it agrees with your own reason
and your own common sense.
-- Buddha
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r755199 - /maven/components/branches/maven-2.1.0-RC/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java
Posted by Brett Porter <br...@apache.org>.
On 18/03/2009, at 9:51 AM, Jason van Zyl wrote:
>
> On 17-Mar-09, at 10:10 AM, Brett Porter wrote:
>
>>
>> On 18/03/2009, at 2:23 AM, Jason van Zyl wrote:
>>
>>> Why are you changing core code in the RC branch after we have
>>> started the RC cycle?
>>>
>>> Can we please leave the code alone in RCs and use the 2.1.x branch
>>> for any non-regression related changes.
>>
>> See the concurrent threads - the change you quoted was an
>> adjustment to the previous one based on Benjamin's assessment. The
>> original change was to better inform users of a difference in
>> compatibility for plugins between 2.0.x and 2.1.0 which is why I
>> merged it. I also said that if this is the only thing left it can
>> wait until 2.1.1 - I don't mind if these get rolled back from the
>> RC branch at all.
>>
>
> Benjamin removed the plugin discovery listener?
No, I made a change to properly report metadata problems to avoid
confusion under an earlier change in 2.1.0 (the thread about the resin
plugin). Benjamin pointed out that the way it was done would run the
checks hundreds of times harmlessly but unnecessarily and suggested
removing the listener after the plugin was loaded, so I did that as
well. Then did the same for the collector as we shouldn't be looking
for mojos in dependencies of the plugin. I beefed up the integration
tests with use cases related to the descriptor and using plugin
dependencies that are plugins themselves, and an additional sanity
check that the inherit-maven-plugin still worked.
- Brett
--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r755199 - /maven/components/branches/maven-2.1.0-RC/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java
Posted by Jason van Zyl <jv...@sonatype.com>.
On 17-Mar-09, at 10:10 AM, Brett Porter wrote:
>
> On 18/03/2009, at 2:23 AM, Jason van Zyl wrote:
>
>> Why are you changing core code in the RC branch after we have
>> started the RC cycle?
>>
>> Can we please leave the code alone in RCs and use the 2.1.x branch
>> for any non-regression related changes.
>
> See the concurrent threads - the change you quoted was an adjustment
> to the previous one based on Benjamin's assessment. The original
> change was to better inform users of a difference in compatibility
> for plugins between 2.0.x and 2.1.0 which is why I merged it. I also
> said that if this is the only thing left it can wait until 2.1.1 - I
> don't mind if these get rolled back from the RC branch at all.
>
Benjamin removed the plugin discovery listener?
> - Brett
>
> --
> Brett Porter
> brett@apache.org
> http://blogs.exist.com/bporter/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
----------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r755199 - /maven/components/branches/maven-2.1.0-RC/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java
Posted by Brett Porter <br...@apache.org>.
On 18/03/2009, at 2:23 AM, Jason van Zyl wrote:
> Why are you changing core code in the RC branch after we have
> started the RC cycle?
>
> Can we please leave the code alone in RCs and use the 2.1.x branch
> for any non-regression related changes.
See the concurrent threads - the change you quoted was an adjustment
to the previous one based on Benjamin's assessment. The original
change was to better inform users of a difference in compatibility for
plugins between 2.0.x and 2.1.0 which is why I merged it. I also said
that if this is the only thing left it can wait until 2.1.1 - I don't
mind if these get rolled back from the RC branch at all.
- Brett
--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org