[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #436: fix: update instance dependency

[GitBox <gi...@apache.org>]

Fine0830 commented on a change in pull request #436:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/436#discussion_r587997270



##########
File path: src/store/modules/topology/index.ts
##########
@@ -643,10 +643,15 @@ const actions: ActionTree<State, any> = {
         for (const call of topoCalls) {
           if (call.detectPoints.includes('CLIENT')) {
             clientIdsC.push(call.id);
-          } else {
+          }
+          if (call.detectPoints.includes('SERVER')) {
             serverIdsC.push(call.id);
           }
         }
+        if (!serverIdsC.length || !clientIdsC.length) {

Review comment:
       >  And will you build request by the matrix of `serverIdsC` and `clientIdsC`?
   
   Yes




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org