You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2017/07/07 20:33:39 UTC

[GitHub] spark issue #18395: [SPARK-20655][core] In-memory KVStore implementation.

Github user vanzin commented on the issue:

    https://github.com/apache/spark/pull/18395
  
    @rxin 
    
    I wasn't planning on this being exposed at the moment; maybe in the future, since this is sort of a "natural" extension point to allow different storage backends for the UI / SHS. 
    
    I'm also not sure how to make something not "publicly accessible"; I'm pretty sure I didn't add this to any doc target, unless it's automatically picked up (i.e. I did not touch the `Unidoc` object in the sbt build). Should I still go and add the `@Private` annotations to public classes? (That's not done by other private modules, such as the networking module, although that one predates `@Private`.)
    
    I'm not super excited about changing package names at this point, but if you feel strongly about it it's not a big deal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org