You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/10/15 22:41:01 UTC

Review Request 63002: Logged when allocator cannot apply offer operation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63002/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

An offer apply operation might fail, and it is
helpful to see the failure in verbose logs.


Diffs
-----

  src/master/allocator/mesos/hierarchical.cpp 22131309a38fc6cbb0a68455f94ef6075076d4e7 


Diff: https://reviews.apache.org/r/63002/diff/1/


Testing
-------

See https://reviews.apache.org/r/63015/


Thanks,

Alexander Rukletsov


Re: Review Request 63002: Logged when allocator cannot apply offer operation.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63002/#review188207
-----------------------------------------------------------


Ship it!





src/master/allocator/mesos/hierarchical.cpp
Lines 922 (patched)
<https://reviews.apache.org/r/63002/#comment265230>

    `s/Fail/Failed/`


- Michael Park


On Oct. 15, 2017, 3:41 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63002/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2017, 3:41 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> An offer apply operation might fail, and it is
> helpful to see the failure in verbose logs.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 22131309a38fc6cbb0a68455f94ef6075076d4e7 
> 
> 
> Diff: https://reviews.apache.org/r/63002/diff/1/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/63015/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>