You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by xt...@apache.org on 2024/01/04 03:40:55 UTC
(flink) branch release-1.18 updated: [FLINK-33939][runtime-web] Remove the husky dependency to make sure the global hooks work as expected
This is an automated email from the ASF dual-hosted git repository.
xtsong pushed a commit to branch release-1.18
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/release-1.18 by this push:
new 8342ac7f1e9 [FLINK-33939][runtime-web] Remove the husky dependency to make sure the global hooks work as expected
8342ac7f1e9 is described below
commit 8342ac7f1e9b52438a3f26bf96b2102c7145dcab
Author: simplejason <si...@gmail.com>
AuthorDate: Tue Dec 26 14:36:35 2023 +0800
[FLINK-33939][runtime-web] Remove the husky dependency to make sure the global hooks work as expected
This closes #23992
---
flink-runtime-web/README.md | 2 ++
flink-runtime-web/web-dashboard/.husky/pre-commit | 6 ------
flink-runtime-web/web-dashboard/package-lock.json | 22 ----------------------
flink-runtime-web/web-dashboard/package.json | 2 --
4 files changed, 2 insertions(+), 30 deletions(-)
diff --git a/flink-runtime-web/README.md b/flink-runtime-web/README.md
index 5a238dbe336..edcbf44c508 100644
--- a/flink-runtime-web/README.md
+++ b/flink-runtime-web/README.md
@@ -102,6 +102,8 @@ re-compilation:
### CodeStyle & Lint
+> Tips: Before committing, make sure you've run `npm run lint-staged` and that no errors are reported.
+
```bash
$ npm run lint
```
diff --git a/flink-runtime-web/web-dashboard/.husky/pre-commit b/flink-runtime-web/web-dashboard/.husky/pre-commit
deleted file mode 100755
index 1bc79ef6815..00000000000
--- a/flink-runtime-web/web-dashboard/.husky/pre-commit
+++ /dev/null
@@ -1,6 +0,0 @@
-#!/usr/bin/env bash
-. "$(dirname "$0")/_/husky.sh"
-
-if ! git diff-index --cached --quiet HEAD -- "flink-runtime-web/web-dashboard/*"; then
- cd flink-runtime-web/web-dashboard && npm run lint-staged
-fi
diff --git a/flink-runtime-web/web-dashboard/package-lock.json b/flink-runtime-web/web-dashboard/package-lock.json
index 6b68dc2a329..d95c10c63ff 100644
--- a/flink-runtime-web/web-dashboard/package-lock.json
+++ b/flink-runtime-web/web-dashboard/package-lock.json
@@ -53,7 +53,6 @@
"eslint-plugin-prefer-arrow": "^1.2.3",
"eslint-plugin-prettier": "^4.0.0",
"eslint-plugin-unused-imports": "^2.0.0",
- "husky": "^7.0.4",
"jasmine-core": "^4.0.0",
"jasmine-spec-reporter": "^7.0.0",
"karma": "~6.3.14",
@@ -10173,21 +10172,6 @@
"ms": "^2.0.0"
}
},
- "node_modules/husky": {
- "version": "7.0.4",
- "resolved": "https://registry.npmjs.org/husky/-/husky-7.0.4.tgz",
- "integrity": "sha512-vbaCKN2QLtP/vD4yvs6iz6hBEo6wkSzs8HpRah1Z6aGmF2KW5PdYuAd7uX5a+OyBZHBhd+TFLqgjUgytQr4RvQ==",
- "dev": true,
- "bin": {
- "husky": "lib/bin.js"
- },
- "engines": {
- "node": ">=12"
- },
- "funding": {
- "url": "https://github.com/sponsors/typicode"
- }
- },
"node_modules/iconv-lite": {
"version": "0.6.3",
"resolved": "https://registry.npmjs.org/iconv-lite/-/iconv-lite-0.6.3.tgz",
@@ -25425,12 +25409,6 @@
"ms": "^2.0.0"
}
},
- "husky": {
- "version": "7.0.4",
- "resolved": "https://registry.npmjs.org/husky/-/husky-7.0.4.tgz",
- "integrity": "sha512-vbaCKN2QLtP/vD4yvs6iz6hBEo6wkSzs8HpRah1Z6aGmF2KW5PdYuAd7uX5a+OyBZHBhd+TFLqgjUgytQr4RvQ==",
- "dev": true
- },
"iconv-lite": {
"version": "0.6.3",
"resolved": "https://registry.npmjs.org/iconv-lite/-/iconv-lite-0.6.3.tgz",
diff --git a/flink-runtime-web/web-dashboard/package.json b/flink-runtime-web/web-dashboard/package.json
index 0c1c9972d0a..c8e3e26730d 100644
--- a/flink-runtime-web/web-dashboard/package.json
+++ b/flink-runtime-web/web-dashboard/package.json
@@ -10,7 +10,6 @@
"lint:fix": "eslint --fix --cache src --ext .ts,.html && stylelint \"**/*.less\" --fix",
"ci-check": "npm run lint && npm run build",
"proxy": "ng serve --proxy-config proxy.conf.json",
- "prepare": "cd ../.. && husky install flink-runtime-web/web-dashboard/.husky",
"lint-staged": "lint-staged"
},
"private": true,
@@ -60,7 +59,6 @@
"eslint-plugin-prefer-arrow": "^1.2.3",
"eslint-plugin-prettier": "^4.0.0",
"eslint-plugin-unused-imports": "^2.0.0",
- "husky": "^7.0.4",
"jasmine-core": "^4.0.0",
"jasmine-spec-reporter": "^7.0.0",
"karma": "~6.3.14",