[jira] [Commented] (SLING-9041) Converter adding .config ending of sling:OsgiConfig nodes to pid

["Dominik Süß (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026780#comment-17026780 ] 

Dominik Süß commented on SLING-9041:
------------------------------------

[~karlpauls] - can you please pick up PR?

> Converter adding .config ending of sling:OsgiConfig nodes to pid
> ----------------------------------------------------------------
>
>                 Key: SLING-9041
>                 URL: https://issues.apache.org/jira/browse/SLING-9041
>             Project: Sling
>          Issue Type: Bug
>          Components: Content-Package to Feature Model Converter
>    Affects Versions: Content-Package to Feature Model Converter 1.0.6
>            Reporter: Dominik Süß
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The extraction logic of the cp2featuremodel converter currently extracts the pid from the name by stripping of the extension after (including) the last dot - this is wrong in context of sling:OsgiConfig nodes as those are serialized as .xml while the nodes themselves have a .config option. The mechanism should be replaced by an adjustment of the already existing pattern-matcher based logic (currently used for detecting the runmodes).
> As consumers may already depend on nodes without the .config ending the endings .config.xml and .xml must be supported in a non-greedy way (if ending with .config.xml the .config shouldn't be part of the capturing group) for backwards compatiblity.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)