You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2013/10/17 22:56:07 UTC
Review Request 14721: Hard tabs in zookeeper
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14721/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Repository: mesos-git
Description
-------
11 lines with hard tabs found in zookeeper (with mesos-style.py). Trivial patch converting hard tabs into spaces.
Diffs
-----
src/zookeeper/zookeeper.cpp de33003
Diff: https://reviews.apache.org/r/14721/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
Re: Review Request 14721: Hard tabs in zookeeper
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14721/#review27161
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Oct. 17, 2013, 10:11 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14721/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2013, 10:11 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> 11 lines with hard tabs found in zookeeper (with mesos-style.py). Trivial patch converting hard tabs into spaces.
>
>
> Diffs
> -----
>
> src/zookeeper/zookeeper.cpp de33003
>
> Diff: https://reviews.apache.org/r/14721/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 14721: Hard tabs in zookeeper
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14721/
-----------------------------------------------------------
(Updated Oct. 17, 2013, 10:11 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
Further call wrapping fixes.
Repository: mesos-git
Description
-------
11 lines with hard tabs found in zookeeper (with mesos-style.py). Trivial patch converting hard tabs into spaces.
Diffs (updated)
-----
src/zookeeper/zookeeper.cpp de33003
Diff: https://reviews.apache.org/r/14721/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
Re: Review Request 14721: Hard tabs in zookeeper
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Oct. 17, 2013, 9:59 p.m., Ben Mahler wrote:
> > Thanks for updating this! Can you fix the wrapping on these three:
> >
> > static void event(zhandle_t* zh, int type, int state,
> > const char* path, void* ctx)
> >
> > static void dataCompletion(int ret, const char* value, int value_len,
> > const Stat* stat, const void* data)
> >
> > static void stringsCompletion(int ret, const String_vector* values,
> > const void* data)
> >
You bet! Should be in new patch.
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14721/#review27154
-----------------------------------------------------------
On Oct. 17, 2013, 10:11 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14721/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2013, 10:11 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> 11 lines with hard tabs found in zookeeper (with mesos-style.py). Trivial patch converting hard tabs into spaces.
>
>
> Diffs
> -----
>
> src/zookeeper/zookeeper.cpp de33003
>
> Diff: https://reviews.apache.org/r/14721/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 14721: Hard tabs in zookeeper
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14721/#review27154
-----------------------------------------------------------
Thanks for updating this! Can you fix the wrapping on these three:
static void event(zhandle_t* zh, int type, int state,
const char* path, void* ctx)
static void dataCompletion(int ret, const char* value, int value_len,
const Stat* stat, const void* data)
static void stringsCompletion(int ret, const String_vector* values,
const void* data)
- Ben Mahler
On Oct. 17, 2013, 9:44 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14721/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2013, 9:44 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> 11 lines with hard tabs found in zookeeper (with mesos-style.py). Trivial patch converting hard tabs into spaces.
>
>
> Diffs
> -----
>
> src/zookeeper/zookeeper.cpp de33003
>
> Diff: https://reviews.apache.org/r/14721/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 14721: Hard tabs in zookeeper
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14721/
-----------------------------------------------------------
(Updated Oct. 17, 2013, 9:44 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
Fix call wrapping
Repository: mesos-git
Description
-------
11 lines with hard tabs found in zookeeper (with mesos-style.py). Trivial patch converting hard tabs into spaces.
Diffs (updated)
-----
src/zookeeper/zookeeper.cpp de33003
Diff: https://reviews.apache.org/r/14721/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen