You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "felipecrv (via GitHub)" <gi...@apache.org> on 2023/06/15 21:54:44 UTC
[GitHub] [arrow] felipecrv opened a new pull request, #36116: MINOR [C++]: Remove cur_offset variable. Correctly this time.
felipecrv opened a new pull request, #36116:
URL: https://github.com/apache/arrow/pull/36116
Fixes an issue introduced yesterday in https://github.com/apache/arrow/pull/35750/commits/7a1f4bde586eb74f196e9b0bee31aebf796635fd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36116: MINOR [C++]: Remove cur_offset variable. Correctly this time.
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36116:
URL: https://github.com/apache/arrow/pull/36116#issuecomment-1596159128
Conbench analyzed the 6 benchmark runs on commit `b6dabdfc`.
There were 3 benchmark results indicating a performance regression:
- Commit Run on `arm64-t4g-linux-compute` at [2023-06-16 14:48:12Z](http://conbench.ursa.dev/compare/runs/eb9887ddec624f28acc0d88fe03dbfc1...f576da13b59843a39faf433dced916e4/)
- [params=not_null_to_is_true_multipass_benchmark/batch_size:100000/null_prob:50/bool_true_prob:50/real_time, source=cpp-micro, suite=arrow-acero-filter-benchmark](http://conbench.ursa.dev/compare/benchmarks/0648c21ff36772508000e1e1480d29fb...0648c7682d067592800072e24fd83d77)
- Commit Run on `arm64-m6g-linux-compute` at [2023-06-16 15:41:46Z](http://conbench.ursa.dev/compare/runs/adb0300d73ad401a8bb137a66a4109ed...378400195edf4c49bf8be1e17c194ca3/)
- [source=cpp-micro, suite=arrow-utf8-util-benchmark](http://conbench.ursa.dev/compare/benchmarks/0648c7e2a9bd7af78000c3bcc0b455b5...0648c82fa22b77bc8000c910ff4336c8)
- and 1 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/14354256846) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz merged pull request #36116: MINOR [C++]: Remove cur_offset variable. Correctly this time.
Posted by "bkietz (via GitHub)" <gi...@apache.org>.
bkietz merged PR #36116:
URL: https://github.com/apache/arrow/pull/36116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] felipecrv commented on pull request #36116: MINOR [C++]: Remove cur_offset variable. Correctly this time.
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on PR #36116:
URL: https://github.com/apache/arrow/pull/36116#issuecomment-1593768710
@bkietz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org