You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/08/25 06:58:22 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request, #42675: [SPARK-42944][PYTHON][FOLLOW-UP] Rename tests from foreachBatch to foreach_batch

HyukjinKwon opened a new pull request, #42675:
URL: https://github.com/apache/spark/pull/42675

   ### What changes were proposed in this pull request?
   
   This PR proposes to rename tests from foreachBatch to foreach_batch.
   
   ### Why are the changes needed?
   
   Non-API should follow snake_naming rule per PEP 8.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, dev-only.
   
   ### How was this patch tested?
   
   CI in this PR should test it out.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #42675: [SPARK-42944][PYTHON][FOLLOW-UP] Rename tests from foreachBatch to foreach_batch

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42675:
URL: https://github.com/apache/spark/pull/42675#issuecomment-1692865546

   cc @WweiL 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #42675: [SPARK-42944][PYTHON][FOLLOW-UP] Rename tests from foreachBatch to foreach_batch

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42675:
URL: https://github.com/apache/spark/pull/42675#issuecomment-1694246392

   BTW, `pyspark-pandas-connect` (3h 12min) and `pyspark-pandas-slow-connect` (3h 33min) seems to take very long time frequently. Do you think we can improve these pipeline?
   - https://github.com/apache/spark/actions/runs/5979206329/job/16222875461
   - https://github.com/apache/spark/actions/runs/5979206329/job/16222875615


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #42675: [SPARK-42944][PYTHON][FOLLOW-UP] Rename tests from foreachBatch to foreach_batch

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #42675: [SPARK-42944][PYTHON][FOLLOW-UP] Rename tests from foreachBatch to foreach_batch
URL: https://github.com/apache/spark/pull/42675


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #42675: [SPARK-42944][PYTHON][FOLLOW-UP] Rename tests from foreachBatch to foreach_batch

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42675:
URL: https://github.com/apache/spark/pull/42675#issuecomment-1695218327

   @itholic mind taking a look at https://github.com/apache/spark/pull/42675#issuecomment-1694246392?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #42675: [SPARK-42944][PYTHON][FOLLOW-UP] Rename tests from foreachBatch to foreach_batch

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42675:
URL: https://github.com/apache/spark/pull/42675#issuecomment-1694569440

   `pyspark-connect` was the only failure last time. Now, it passed. Merged to master.
   
   ![Screenshot 2023-08-26 at 9 50 41 PM](https://github.com/apache/spark/assets/9700541/2efdb9c6-c865-418b-a221-0c7691d2734d)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #42675: [SPARK-42944][PYTHON][FOLLOW-UP] Rename tests from foreachBatch to foreach_batch

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42675:
URL: https://github.com/apache/spark/pull/42675#issuecomment-1694569670

   There is a conflict on branch-3.5. Please make a backporting PR on `branch-3.5` please.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #42675: [SPARK-42944][PYTHON][FOLLOW-UP] Rename tests from foreachBatch to foreach_batch

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42675:
URL: https://github.com/apache/spark/pull/42675#issuecomment-1694576724

   Will do. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #42675: [SPARK-42944][PYTHON][FOLLOW-UP] Rename tests from foreachBatch to foreach_batch

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42675:
URL: https://github.com/apache/spark/pull/42675#issuecomment-1694402771

   It seems that `pyspark-connect` module took 6 hours and was cancelled by timeout. Could you re-run?
   
   ![Screenshot 2023-08-26 at 9 24 39 AM](https://github.com/apache/spark/assets/9700541/91b1aebe-cf24-4765-8536-5e22a2eb6bc2)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #42675: [SPARK-42944][PYTHON][FOLLOW-UP] Rename tests from foreachBatch to foreach_batch

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42675:
URL: https://github.com/apache/spark/pull/42675#issuecomment-1694828581

   https://github.com/apache/spark/pull/42692


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org