You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "gengliangwang (via GitHub)" <gi...@apache.org> on 2025/11/25 19:03:58 UTC
[PR] [SPARK-54506][CORE] Add $init$ method to LogKey for backward compatibility [spark]
gengliangwang opened a new pull request, #53217:
URL: https://github.com/apache/spark/pull/53217
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Follow-up of https://issues.apache.org/jira/browse/SPARK-53064.
Add a static `$init$` method to the `LogKey` interface for backward compatibility with libraries compiled against Spark 4.0 where `LogKey` was a Scala trait.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
In Spark 4.0, `LogKey` was a Scala trait which generates a `$init$` method during compilation. Libraries like Delta Lake compiled against Spark 4.0 expect this method to exist. Since `LogKey` has been changed to a Java interface, calling the `$init$` method throws `NoSuchMethodError`:
```
java.lang.NoSuchMethodError: 'void org.apache.spark.internal.LogKey.$init$(org.apache.spark.internal.LogKey)'
```
This change adds an empty `$init$` static method to maintain binary compatibility.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Added a new test `LogKeySuite` to verify the `$init$` method exists and can be called without throwing an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54506][CORE] Add $init$ method to LogKey for backward compatibility [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #53217:
URL: https://github.com/apache/spark/pull/53217#issuecomment-3578767090
@gengliangwang, I think this is an expected behavior, SPARK-53064 only provides a feasible approach to allow developers to write a custom `LogKey` that keeps binary compatibility with Spark 4.0 and 4.1.
From my knowledge, downstream projects that heavily use the Spark internal API are hard to maintain binary compatibility across Spark feature versions. One example is that Iceberg used to do that in the Spark 3.0 and 3.1 period, and decided to abandon that after a short time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54506][CORE] Add $init$ method to LogKey for backward compatibility [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #53217:
URL: https://github.com/apache/spark/pull/53217#issuecomment-3577720018
Thank you for closing this PR~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54506][CORE] Add $init$ method to LogKey for backward compatibility [spark]
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang closed pull request #53217: [SPARK-54506][CORE] Add $init$ method to LogKey for backward compatibility
URL: https://github.com/apache/spark/pull/53217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54506][CORE] Add $init$ method to LogKey for backward compatibility [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #53217:
URL: https://github.com/apache/spark/pull/53217#issuecomment-3577709514
> > I don't think we need this PR, do we?
>
> @dongjoon-hyun It helps avoid potential backward-compatibility issues if external code extends the `LogKey` trait in Spark 4.0. It would be good to address this here.
+1 for your passion. However, I don't think that's the Apache Spark community API contract. Moreover, your claim is very misleading because the Scala version is also different between 4.0 and 4.1. I don't think we can claim that 3rd-party libraries compiled with Scala 2.13.16 can work with Spark 4.1 (on Scala 2.13.17) without any issue.
Given that, let's not do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54506][CORE] Add $init$ method to LogKey for backward compatibility [spark]
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang commented on PR #53217:
URL: https://github.com/apache/spark/pull/53217#issuecomment-3577716048
@dongjoon-hyun ok, I don't have strong opinion on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54506][CORE] Add $init$ method to LogKey for backward compatibility [spark]
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang commented on PR #53217:
URL: https://github.com/apache/spark/pull/53217#issuecomment-3577692500
> I don't think we need this PR, do we?
@dongjoon-hyun It helps avoid potential backward-compatibility issues if external code extends the `LogKey` trait in Spark 4.0. It would be good to address this here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54506][CORE] Add $init$ method to LogKey for backward compatibility [spark]
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang commented on PR #53217:
URL: https://github.com/apache/spark/pull/53217#issuecomment-3577146164
cc @pan3793 as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org