Re: svn commit: r713923 - /ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl

[David E Jones <de...@me.com>]

This isn't a good label to use for this purpose. Please create a new  
one in the Common or Ecommerce files, or find an existing on in the  
party or security components.

The "Account" referred to in the Accounting labels is a more like a  
General Ledger, Financial, or Billing "account" and not a user login  
or customer account which is what this refers to. These are different  
concepts, and may use different words in different languages.

As a generality, try to use labels from components that make sense. In  
this case user login and customer accounts have nothing to do with  
accounting, but do have to do with party and security... so those  
would be more logical places to look.

-David


On Nov 14, 2008, at 12:17 AM, mor@apache.org wrote:

> Author: mor
> Date: Thu Nov 13 22:17:17 2008
> New Revision: 713923
>
> URL: http://svn.apache.org/viewvc?rev=713923&view=rev
> Log:
> Applied patch from Rishi Solanki from Jira Issue OFBIZ-2038 (https://issues.apache.org/jira/browse/OFBIZ-2038 
> ). This is about adding a link to ecommerce header that will prompt  
> guest user to create a new account.
>
> Modified:
>    ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/ 
> header.ftl
>
> Modified: ofbiz/trunk/applications/ecommerce/webapp/ecommerce/ 
> includes/header.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl?rev=713923&r1=713922&r2=713923&view=diff
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/ 
> header.ftl (original)
> +++ ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/ 
> header.ftl Thu Nov 13 22:17:17 2008
> @@ -100,6 +100,7 @@
>             <li id="header-bar-logout"><a href="<@ofbizUrl>logout</ 
> @ofbizUrl>">${uiLabelMap.CommonLogout}</a></li>
>         <#else/>
>             <li id="header-bar-login"><a href="<@ofbizUrl>$ 
> {checkLoginUrl}</...@ofbizUrl>">${uiLabelMap.CommonLogin}</a></li>
> +            <li id="header-bar-login"><a  
> href="<@o...@ofbizUrl>">$ 
> {uiLabelMap.AccountingNewAccount}</a></li>
>         </#if>
>         <li id="header-bar-contactus"><a href="<@ofbizUrl>contactus</ 
> @ofbizUrl>">${uiLabelMap.CommonContactUs}</a></li>
>         <li id="header-bar-main"><a href="<@ofbizUrl>main</ 
> @ofbizUrl>">${uiLabelMap.CommonMain}</a></li>
>
>

Re: svn commit: r713923 - /ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl

[Rishi Solanki <ri...@gmail.com>]

Sorry, It was my mistake I will upload the patch on the jira issue with a
new uiLable in the E commerce of value "Register".
please find the patch at -- https://issues.apache.org/jira/browse/OFBIZ-2038

Thanks !
- Rishi Solanki

On Fri, Nov 14, 2008 at 11:57 AM, David E Jones <de...@me.com> wrote:

>
> This isn't a good label to use for this purpose. Please create a new one in
> the Common or Ecommerce files, or find an existing on in the party or
> security components.
>
> The "Account" referred to in the Accounting labels is a more like a General
> Ledger, Financial, or Billing "account" and not a user login or customer
> account which is what this refers to. These are different concepts, and may
> use different words in different languages.
>
> As a generality, try to use labels from components that make sense. In this
> case user login and customer accounts have nothing to do with accounting,
> but do have to do with party and security... so those would be more logical
> places to look.
>
> -David
>
>
>
> On Nov 14, 2008, at 12:17 AM, mor@apache.org wrote:
>
>  Author: mor
>> Date: Thu Nov 13 22:17:17 2008
>> New Revision: 713923
>>
>> URL: http://svn.apache.org/viewvc?rev=713923&view=rev
>> Log:
>> Applied patch from Rishi Solanki from Jira Issue OFBIZ-2038 (
>> https://issues.apache.org/jira/browse/OFBIZ-2038). This is about adding a
>> link to ecommerce header that will prompt guest user to create a new
>> account.
>>
>> Modified:
>>   ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl
>>
>> Modified:
>> ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl?rev=713923&r1=713922&r2=713923&view=diff
>>
>> ==============================================================================
>> ---
>> ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl
>> (original)
>> +++
>> ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl Thu
>> Nov 13 22:17:17 2008
>> @@ -100,6 +100,7 @@
>>            <li id="header-bar-logout"><a
>> href="<@o...@ofbizUrl>">${uiLabelMap.CommonLogout}</a></li>
>>        <#else/>
>>            <li id="header-bar-login"><a
>> href="<@o...@ofbizUrl>">${uiLabelMap.CommonLogin}</a></li>
>> +            <li id="header-bar-login"><a
>> href="<@o...@ofbizUrl>">${uiLabelMap.AccountingNewAccount}</a></li>
>>        </#if>
>>        <li id="header-bar-contactus"><a
>> href="<@o...@ofbizUrl>">${uiLabelMap.CommonContactUs}</a></li>
>>        <li id="header-bar-main"><a
>> href="<@o...@ofbizUrl>">${uiLabelMap.CommonMain}</a></li>
>>
>>
>>
>


-- 
Rishi Solanki
Enterprise Software Developer
HotWax Media Pvt. Ltd.