You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/02/18 22:08:37 UTC
[GitHub] [trafficserver] AD5GB opened a new pull request #8680: Fix missing unique_lock definition.
AD5GB opened a new pull request #8680:
URL: https://github.com/apache/trafficserver/pull/8680
Build of master fails on Arch and Fedora (x86_64 and aarch64), Centos 8 and RHEL-8.5 (x86_64).
This fixes the missing definition.
Signed-off-by: Randy DuCharme <ra...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt merged pull request #8680: Fix missing unique_lock definition.
Posted by GitBox <gi...@apache.org>.
bneradt merged pull request #8680:
URL: https://github.com/apache/trafficserver/pull/8680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8680: Fix missing unique_lock definition.
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8680:
URL: https://github.com/apache/trafficserver/pull/8680#issuecomment-1048071191
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] AD5GB commented on pull request #8680: Fix missing unique_lock definition.
Posted by GitBox <gi...@apache.org>.
AD5GB commented on pull request #8680:
URL: https://github.com/apache/trafficserver/pull/8680#issuecomment-1045902007
Well, you *could* make Clang-xx a requirement; all other toolchains
unsupported 😉.
I wonder then if the #include should be conditional somehow then. My
personal preference is to *not* have code littered with a large amount
of #ifdef/#ifndef #endif statements but depending on project goals it
sometimes becomes necessary.
I'm actually grappling with some of this trying to get it to build on
OmniOS. I'm looking into GNU configure tools for a lot of that though
as I really haven't worked much with them.
Anyway, thanks for all that you do!
On 2/18/2022 5:18 PM, Brian Neradt wrote:
>
> ***@***.**** approved this pull request.
>
> Thanks for the fix.
>
> I'm updating CI to use gcc-11 to catch these during the PR checks.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/trafficserver/pull/8680#pullrequestreview-887831575>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABHLI3ZF73VBVEFCHX5LEJLU33HSZANCNFSM5OZGSLNA>.
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you were assigned.Message ID:
> ***@***.***>
>
--
Randall DuCharme (Radio AD5GB)
Powered entirely by Open Source software.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org