You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/12/12 23:11:45 UTC

[GitHub] [openwhisk-package-cloudant] benizl commented on a change in pull request #220: Remove console.{log, error} from most parts of the codebase

benizl commented on a change in pull request #220: Remove console.{log,error} from most parts of the codebase
URL: https://github.com/apache/openwhisk-package-cloudant/pull/220#discussion_r357417877
 
 

 ##########
 File path: actions/event-actions/lib/common.js
 ##########
 @@ -132,7 +130,7 @@ function constructObject(data) {
                 jsonObject = JSON.parse(data);
             }
             catch (e) {
-                console.log('error parsing ' + data);
+                console.error('error parsing ' + data);
 
 Review comment:
   It's a good point, I'm not 100% sure either way. The only place where this is used is building `additionalData` when creating a trigger in the `changesWebAction`. My understanding is that that's a configuration object and wouldn't sensibly contain user data, but I'd be interested in others' analysis?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services