You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/02/01 00:52:50 UTC

[GitHub] merlimat opened a new pull request #1164: Remove toString() invocation in dispatcher path

merlimat opened a new pull request #1164: Remove toString() invocation in dispatcher path
URL: https://github.com/apache/incubator-pulsar/pull/1164
 
 
   ### Motivation
   
   During message dispatch a `Subscription.toString()` is invoked for each message (or batch) with no purpose other than debug logs which are not shown.
   
   This is generating lots of `String`, `char[]`, `StringBuilder`, etc.
   
   ### Modifications
   
   Pass along the `Subscription` instance so that `toString()` is only invoked when printing debug logs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services