[GitHub] [spark] HyukjinKwon commented on a change in pull request #34715: [SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #34715:
URL: https://github.com/apache/spark/pull/34715#discussion_r759983638



##########
File path: python/pyspark/install.py
##########
@@ -65,7 +68,7 @@ def checked_versions(spark_version, hadoop_version, hive_version):
 
     if hadoop_version == "without":
         hadoop_version = "without-hadoop"
-    elif re.match("^[0-9]+\\.[0-9]+$", hadoop_version):
+    elif re.match("^[0-9]+$", hadoop_version):

Review comment:
       Oh, I think actually @AngersZhuuuu covered old version logics too.  There are some tests at `test_install_spark.py` below. For testing, it always use old versions. For releases, it always uses the corresponding version string (e.g., if pip install pyspark==3.2.0, `spark_version` is always `3.2.0`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org