You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/04/19 09:08:42 UTC
[GitHub] [parquet-mr] Fokko opened a new pull request, #1075: PARQUET-2289: Avoid using `hasCapability`
Fokko opened a new pull request, #1075:
URL: https://github.com/apache/parquet-mr/pull/1075
We should avoid using `hasCapability` to maintain compatibility with Hadoop 2. I think we can remove the whole check since Hadoop 1 isn't supported anymore.
This allows us to use Hadoop 2. Relates to https://github.com/apache/parquet-mr/pull/951
cc @steveloughran
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] steveloughran commented on pull request #1075: PARQUET-2289: Avoid using `hasCapability`
Posted by "steveloughran (via GitHub)" <gi...@apache.org>.
steveloughran commented on PR #1075:
URL: https://github.com/apache/parquet-mr/pull/1075#issuecomment-1514518094
StreamCapabilities was added to hadoop branch 2 *six years ago* in https://issues.apache.org/jira/browse/HDFS-11644 and shipped in hadoop-2.9.0
anyone complaining about it not being there is trying to run a version of hadoop which predates this, and is not the version of hadoop-2 parquet compiles with. There is no guarantee *anything* works with that older version: method signatures, dependencies. etc.
oh, and if you really want to claim hadoop 2.8.x support, you have to compile with java7 too, as hadoop 2.9 is the first java8 compatible release
If you really want to support it, you need to modify the build to
* compile with java lang == 7
* require a java7 jdk
* build against hadoop 2.8
or you tell the user complaining to upgrade to a release of hadoop which has shipped recently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] Fokko commented on pull request #1075: PARQUET-2289: Avoid using `hasCapability`
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #1075:
URL: https://github.com/apache/parquet-mr/pull/1075#issuecomment-1514523280
@steveloughran thanks for the insight. I thought this would be rather trivial, but this clearly isn't the case. Adding support for Java 7 is something that doesn't make any sense. Let me close this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] Fokko closed pull request #1075: PARQUET-2289: Avoid using `hasCapability`
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko closed pull request #1075: PARQUET-2289: Avoid using `hasCapability`
URL: https://github.com/apache/parquet-mr/pull/1075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] steveloughran commented on pull request #1075: PARQUET-2289: Avoid using `hasCapability`
Posted by "steveloughran (via GitHub)" <gi...@apache.org>.
steveloughran commented on PR #1075:
URL: https://github.com/apache/parquet-mr/pull/1075#issuecomment-1514688456
aah, no worries. i just despair when people ask for things backported to 5+ year old releases because they don't want the hassle of upgrading their own installation, e.g [HADOOP-18600](https://issues.apache.org/jira/browse/HADOOP-18600). My PoV there is "you are free to fork your own versions of things and maintain them" -the maintenance being what is expected.
Whoever doesn't upgrade also gets to maintain their CVE fix process, both from hadoop and all the dependencies, so I would use the latest hadoop 2.9.x release, as at least there we fix all the hadoop source fixes we can, even though transitive JAR updates are out of scope. A six year old release has 6 years worth of security related JAR updates to worry about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org