You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "chickenlj (via GitHub)" <gi...@apache.org> on 2023/12/15 02:41:14 UTC
[PR] Add dockerfile support, update native support [dubbo-initializer]
chickenlj opened a new pull request, #29:
URL: https://github.com/apache/dubbo-initializer/pull/29
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Add dockerfile support, update native support [dubbo-initializer]
Posted by "CrazyHZM (via GitHub)" <gi...@apache.org>.
CrazyHZM commented on code in PR #29:
URL: https://github.com/apache/dubbo-initializer/pull/29#discussion_r1427519723
##########
initializer-generator/src/main/java/org/apache/dubbo/initializer/generation/extension/build/maven/NativeMavenPluginCustomizer.java:
##########
@@ -17,19 +17,32 @@
package org.apache.dubbo.initializer.generation.extension.build.maven;
import io.spring.initializr.generator.buildsystem.maven.MavenBuild;
+import io.spring.initializr.generator.buildsystem.maven.MavenProfile;
+import io.spring.initializr.generator.project.ProjectDescription;
import io.spring.initializr.generator.spring.build.BuildCustomizer;
public class NativeMavenPluginCustomizer implements BuildCustomizer<MavenBuild> {
+
+ private ProjectDescription description;
+
+ public NativeMavenPluginCustomizer(ProjectDescription description) {
+ this.description = description;
+ }
+
@Override
public void customize(MavenBuild mavenBuild) {
- mavenBuild.plugins().add("org.springframework.boot", "spring-boot-maven-plugin", builder -> {
+ MavenProfile profile = mavenBuild.profiles().id("native");
+
+ profile.plugins().add("org.springframework.boot", "spring-boot-maven-plugin", builder -> {
+ builder.version("${spring-boot.version}");
+ builder.configuration(conf -> conf.add("mainClass", description.getPackageName() + "." + description.getApplicationName()));
builder.execution("process-aot", executionBuilder -> {
executionBuilder.goal("process-aot");
});
- builder.execution("repackage", execution -> execution.goal("repackage"));
+// builder.execution("repackage", execution -> execution.goal("repackage"));
});
- mavenBuild.plugins().add("org.graalvm.buildtools", "native-maven-plugin", builder -> {
+ profile.plugins().add("org.graalvm.buildtools", "native-maven-plugin", builder -> {
builder.version("0.9.20")
Review Comment:
Bump version to 0.9.28.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Add dockerfile support, update native support [dubbo-initializer]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on PR #29:
URL: https://github.com/apache/dubbo-initializer/pull/29#issuecomment-1857197888

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Add dockerfile support, update native support [dubbo-initializer]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj merged PR #29:
URL: https://github.com/apache/dubbo-initializer/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org