[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1414: fix: check delete successfully to ensure every delete option finished

[GitBox <gi...@apache.org>]

liuxiran commented on a change in pull request #1414:
URL: https://github.com/apache/apisix-dashboard/pull/1414#discussion_r568483377



##########
File path: web/cypress/integration/plugin/create-edit-delete-plugin.spec.js
##########
@@ -63,16 +65,18 @@ context('Create and Delete Plugin List', () => {
 
   it('should delete plugin list', () => {
     cy.visit('/plugin/list');
-    cy.get(domSelector.refresh).click();
+    cy.get('.ant-btn-dangerous').should('exist');
+
     cy.get(domSelector.tableCell, { timeout }).should('exist').then(function (rows) {
       [...rows].forEach((row) => {
         const name = row.innerText;
-        const cases = this.cases[name] || [];

Review comment:
       you mean not all the plugins in the data-list will appear in the plugin list after the create and edit cases finished right? 
   
   yap, It might make more sense to take the number of delete buttons as loop parameters. Let me try
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org