You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/14 17:15:02 UTC

[GitHub] [spark] gengliangwang opened a new pull request #24369: [SPARK-27459][SQL] Revise the exception message of schema inference failure in file source V2

gengliangwang opened a new pull request #24369: [SPARK-27459][SQL] Revise the exception message of schema inference failure in file source V2
URL: https://github.com/apache/spark/pull/24369
 
 
   ## What changes were proposed in this pull request?
   
   Since https://github.com/apache/spark/pull/23383/files#diff-db4a140579c1ac4b1dbec7fe5057eecaR36, the exception message of schema inference failure in file source V2 is `tableName`, which is equivalent to `shortName + path`.
   
   While in file source V1, the message is `Unable to infer schema from ORC/CSV/JSON...`. 
   We should make the message in V2 consistent with V1, so that in the future migration the related test cases don't need to be modified. https://github.com/apache/spark/pull/24058#pullrequestreview-226364350
   
   ## How was this patch tested?
   
   Revert the modified unit test cases in https://github.com/apache/spark/pull/24005/files#diff-b9ddfbc9be8d83ecf100b3b8ff9610b9R431 and https://github.com/apache/spark/pull/23383/files#diff-9ab56940ee5a53f2bb81e3c008653362R577, and test with them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org