You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "StevenLuMT (via GitHub)" <gi...@apache.org> on 2023/01/29 11:54:03 UTC
[GitHub] [pulsar] StevenLuMT opened a new issue, #19350: PIP-244: Refactor ByteBuf release method
StevenLuMT opened a new issue, #19350:
URL: https://github.com/apache/pulsar/issues/19350
### Motivation
It may throw an exception when release a `ByteBuf` object. so the exception in `ByteBuf.release` should be checked.
### Goal
Use `ReferenceCountUtil.safeRelease()` instead of `ByteBuf.release()` in all BooKKeeper's classes.
### API Changes
_No response_
### Implementation
1. Use `ReferenceCountUtil.safeRelease()` instead of `ByteBuf.release()`.
### Alternatives
_No response_
### Anything else?
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] PIP-244: Refactor ByteBuf release method [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari closed issue #19350: PIP-244: Refactor ByteBuf release method
URL: https://github.com/apache/pulsar/issues/19350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] PIP-244: Refactor ByteBuf release method [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on issue #19350:
URL: https://github.com/apache/pulsar/issues/19350#issuecomment-2411090379
Rejecting this proposal since it's the wrong solution to use `safeRelease`. It hides real issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #19350: PIP-244: Refactor ByteBuf release method
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #19350:
URL: https://github.com/apache/pulsar/issues/19350#issuecomment-1449212666
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org