You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "chibenwa (via GitHub)" <gi...@apache.org> on 2023/04/21 03:56:29 UTC

[GitHub] [james-project] chibenwa commented on a diff in pull request #1501: JAMES-4865 Add FutureRelease Extension

chibenwa commented on code in PR #1501:
URL: https://github.com/apache/james-project/pull/1501#discussion_r1173278941


##########
server/apps/distributed-app/docs/modules/ROOT/pages/configure/smtp-hooks.adoc:
##########
@@ -301,4 +301,21 @@ Example configuration:
     <!-- ... -->
     <handler class="org.apache.james.smtpserver.fastfail.ValidSenderDomainHandler"/>
 </handlerchain>
+....
+
+== FUTURERELEASE hooks
+
+The Distributed server has optional support for FUTURERELEASE (link:https://www.rfc-editor.org/rfc/rfc4865.html[RFC-4865])
+
+....
+<smtpserver enabled="true">
+    <...> <!-- The rest of your SMTP configuration, unchanged -->
+    <handlerchain>
+    <handlerchain>
+        <handler class="org.apache.james.smtpserver.futurerelease.FutureReleaseEHLOHook"/>
+        <handler class="org.apache.james.smtpserver.futurerelease.FutureReleaseMailParameterHook"/>
+        <handler class="org.apache.james.smtpserver.CoreCmdHandlerLoader"/>
+    </handlerchain>
+    </handlerchain>
+</smtpserver>

Review Comment:
   ```suggestion
       <...> <!-- The rest of your SMTP configuration, unchanged -->
       <handlerchain>
           <handler class="org.apache.james.smtpserver.futurerelease.FutureReleaseEHLOHook"/>
           <handler class="org.apache.james.smtpserver.futurerelease.FutureReleaseMailParameterHook"/>
           <handler class="org.apache.james.smtpserver.CoreCmdHandlerLoader"/>
       </handlerchain>
   </smtpserver>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org