You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2016/12/14 10:05:57 UTC
Review Request 54734: BG operations modal windows are too small to
show the content (in certain scenarios) [Chrome]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54734/
-----------------------------------------------------------
Review request for Ambari, Aleksandr Kovalenko, Alexandr Antonenko, and Andrii Tkach.
Bugs: ambari-19196
https://issues.apache.org/jira/browse/ambari-19196
Repository: ambari
Description
-------
1. Login to Ambari
2. Click on BG operations.
3. Click on some action link which have relatively lesser content, e.g Hosts, with only one host link.
4. Click on the link to get more details
5. Intermittently the details window also have the same dimension of the previous window and as a result the user is not able to view the content
BG operations modal window should be resizable as intermittently modal windows are too small to view the content[Chrome].
This behavior is observed when we navigate to the granular details and the previous window was smaller size due to lesser content. Please see the screenshots
Intermittently the details window also have the same dimension of the previous window and as a result the user is not able to view the content
Diffs
-----
ambari-web/app/views/common/modal_popup.js a643b23
ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js f3f05a4
Diff: https://reviews.apache.org/r/54734/diff/
Testing
-------
19878 tests complete (40 seconds)
155 tests pending
Thanks,
Oleg Nechiporenko
Re: Review Request 54734: BG operations modal windows are too small
to show the content (in certain scenarios) [Chrome]
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54734/#review159127
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On Dec. 14, 2016, 10:05 a.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54734/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 10:05 a.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko, Alexandr Antonenko, and Andrii Tkach.
>
>
> Bugs: ambari-19196
> https://issues.apache.org/jira/browse/ambari-19196
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Login to Ambari
> 2. Click on BG operations.
> 3. Click on some action link which have relatively lesser content, e.g Hosts, with only one host link.
> 4. Click on the link to get more details
> 5. Intermittently the details window also have the same dimension of the previous window and as a result the user is not able to view the content
>
> BG operations modal window should be resizable as intermittently modal windows are too small to view the content[Chrome].
> This behavior is observed when we navigate to the granular details and the previous window was smaller size due to lesser content. Please see the screenshots
>
> Intermittently the details window also have the same dimension of the previous window and as a result the user is not able to view the content
>
>
> Diffs
> -----
>
> ambari-web/app/views/common/modal_popup.js a643b23
> ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js f3f05a4
>
> Diff: https://reviews.apache.org/r/54734/diff/
>
>
> Testing
> -------
>
> 19878 tests complete (40 seconds)
> 155 tests pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 54734: BG operations modal windows are too small
to show the content (in certain scenarios) [Chrome]
Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54734/#review159128
-----------------------------------------------------------
Ship it!
Ship It!
- Andriy Babiichuk
On \u0413\u0440\u0443. 14, 2016, 10:05 \u0434\u043e \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54734/
> -----------------------------------------------------------
>
> (Updated \u0413\u0440\u0443. 14, 2016, 10:05 \u0434\u043e \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
>
>
> Review request for Ambari, Aleksandr Kovalenko, Alexandr Antonenko, and Andrii Tkach.
>
>
> Bugs: ambari-19196
> https://issues.apache.org/jira/browse/ambari-19196
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Login to Ambari
> 2. Click on BG operations.
> 3. Click on some action link which have relatively lesser content, e.g Hosts, with only one host link.
> 4. Click on the link to get more details
> 5. Intermittently the details window also have the same dimension of the previous window and as a result the user is not able to view the content
>
> BG operations modal window should be resizable as intermittently modal windows are too small to view the content[Chrome].
> This behavior is observed when we navigate to the granular details and the previous window was smaller size due to lesser content. Please see the screenshots
>
> Intermittently the details window also have the same dimension of the previous window and as a result the user is not able to view the content
>
>
> Diffs
> -----
>
> ambari-web/app/views/common/modal_popup.js a643b23
> ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js f3f05a4
>
> Diff: https://reviews.apache.org/r/54734/diff/
>
>
> Testing
> -------
>
> 19878 tests complete (40 seconds)
> 155 tests pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>