You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2018/09/15 22:50:07 UTC

logging-log4j2 git commit: [LOG4J2-2447] Let the NullAppender default its name to "null".

Repository: logging-log4j2
Updated Branches:
  refs/heads/release-2.x fd5b34ed4 -> fe8d9f9b6


[LOG4J2-2447] Let the NullAppender default its name to "null".

Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/fe8d9f9b
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/fe8d9f9b
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/fe8d9f9b

Branch: refs/heads/release-2.x
Commit: fe8d9f9b62adb54c0963264ffdc8ce5ddb2764ac
Parents: fd5b34e
Author: Gary Gregory <gg...@rocketsoftware.com>
Authored: Sat Sep 15 16:50:03 2018 -0600
Committer: Gary Gregory <gg...@rocketsoftware.com>
Committed: Sat Sep 15 16:50:03 2018 -0600

----------------------------------------------------------------------
 .../log4j/core/appender/NullAppender.java       | 30 +++++++++++---------
 src/changes/changes.xml                         |  3 ++
 2 files changed, 19 insertions(+), 14 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/fe8d9f9b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/NullAppender.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/NullAppender.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/NullAppender.java
index b37b637..3fc83f3 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/NullAppender.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/NullAppender.java
@@ -24,26 +24,28 @@ import org.apache.logging.log4j.core.config.plugins.PluginAttribute;
 import org.apache.logging.log4j.core.config.plugins.PluginFactory;
 
 /**
- * An Appender that ignores log events. Use for compatibility with version 1.2 and handy for composing a {@link ScriptAppenderSelector}.
+ * An Appender that ignores log events. Use for compatibility with version 1.2
+ * and handy for composing a {@link ScriptAppenderSelector}.
  */
 @Plugin(name = NullAppender.PLUGIN_NAME, category = Core.CATEGORY_NAME, elementType = Appender.ELEMENT_TYPE, printObject = true)
 public class NullAppender extends AbstractAppender {
 
-    public static final String PLUGIN_NAME = "Null";
+	public static final String PLUGIN_NAME = "Null";
 
-    @PluginFactory
-    public static NullAppender createAppender(@PluginAttribute("name") final String name) {
-        return new NullAppender(name);
-    }
+	@PluginFactory
+	public static NullAppender createAppender(
+			@PluginAttribute(value = "smtpPort", defaultString = "null") final String name) {
+		return new NullAppender(name);
+	}
 
-    private NullAppender(final String name) {
-        super(name, null, null);
-        // Do nothing
-    }
+	private NullAppender(final String name) {
+		super(name, null, null);
+		// Do nothing
+	}
 
-    @Override
-    public void append(final LogEvent event) {
-        // Do nothing
-    }
+	@Override
+	public void append(final LogEvent event) {
+		// Do nothing
+	}
 
 }

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/fe8d9f9b/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index dbd0f66..57f1d69 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -61,6 +61,9 @@
       <action issue="LOG4J2-2444" dev="ckozak" type="fix">
         ErrorHandler is invoked with a LogEvent and Throwable when possible, where previously only a string was used.
       </action>
+      <action issue="LOG4J2-2447" dev="ggregory" type="update">
+        Let the NullAppender default its name to "null".
+      </action>
     </release>
     <release version="2.11.1" date="2018-07-22" description="GA Release 2.11.1">
       <action issue="LOG4J2-2389" dev="rgoers" type="fix" due-to="Liu Wen">