You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by huor <gi...@git.apache.org> on 2016/01/14 09:09:22 UTC

[GitHub] incubator-hawq pull request: HAWQ-341. PL functions core dump due ...

GitHub user huor opened a pull request:

    https://github.com/apache/incubator-hawq/pull/267

    HAWQ-341. PL functions core dump due to query resource is not properly allocated for function/table function/sub-query

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/huor/incubator-hawq github_huor_udf

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/267.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #267
    
----
commit bc4139085a73aad63fbc9555850a1c7eda303cad
Author: Ruilong Huo <rh...@pivotal.io>
Date:   2016-01-14T08:07:24Z

    HAWQ-341. PL functions core dump due to query resource is not properly allocated for function/table function/sub-query

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-341. PL functions core dump due ...

Posted by huor <gi...@git.apache.org>.
Github user huor closed the pull request at:

    https://github.com/apache/incubator-hawq/pull/267


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-341. PL functions core dump due ...

Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/267#discussion_r49697810
  
    --- Diff: src/backend/optimizer/plan/planner.c ---
    @@ -443,7 +443,7 @@ planner(Query *parse, int cursorOptions,
     	}
     	PG_END_TRY();
     
    -	if (plannerLevel == 1)
    +	if (plannerLevel >= 1)
     	{
     		resourceNegotiateDone = false;
    --- End diff --
    
    line448: resourceNegotiateDone = false;
    is useless and should be deleted


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-341. PL functions core dump due ...

Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/267#issuecomment-171569970
  
    LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-341. PL functions core dump due ...

Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/267#issuecomment-171570609
  
    +1 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---