You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/12/26 16:05:40 UTC

[GitHub] [incubator-brpc] leaf-potato opened a new pull request, #2064: delete deprecated logoff_ms gflag in example folder

leaf-potato opened a new pull request, #2064:
URL: https://github.com/apache/incubator-brpc/pull/2064

   ### What problem does this PR solve?
   
   Issue Number: #2060
   
   Problem Summary: logoff_ms gflag in example is not used.
   
   ### What is changed and the side effects?
   
   Changed: delete deprecated logoff_ms gflag in example folder.
   
   Side effects:
   - Performance effects(性能影响): no
   
   - Breaking backward compatibility(向后兼容性): yes
   
   ---
   ### Check List:
   - Please make sure your changes are compilable(请确保你的更改可以通过编译).
   - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
   - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] wwbmmm merged pull request #2064: delete deprecated logoff_ms gflag in example folder

Posted by GitBox <gi...@apache.org>.
wwbmmm merged PR #2064:
URL: https://github.com/apache/incubator-brpc/pull/2064


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] serverglen commented on pull request #2064: delete deprecated logoff_ms gflag in example folder

Posted by GitBox <gi...@apache.org>.
serverglen commented on PR #2064:
URL: https://github.com/apache/incubator-brpc/pull/2064#issuecomment-1365553587

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org