You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Phil Adams (JIRA)" <ji...@apache.org> on 2010/10/15 23:54:33 UTC

[jira] Created: (AXIS2-4855) Support new SOAP/JMS binding ID

Support new SOAP/JMS binding ID
-------------------------------

                 Key: AXIS2-4855
                 URL: https://issues.apache.org/jira/browse/AXIS2-4855
             Project: Axis2
          Issue Type: Improvement
          Components: jaxws, kernel
            Reporter: Phil Adams


The W3C SOAP/JMS binding specification (located here: http://www.w3.org/2002/ws/soapjms/) is nearing its first approved version, and has defined a more up to date binding ID for use in the @BindingType annotation (for JAX-WS endpoint impl classes) and within the soap:binding transport attribute within a WSDL document.    Previously, the SOAP/JMS spec defined this binding ID:
   http://www.example.org/2006/06/soap/bindings/JMS/
but has amended that to this new binding ID to reflect the year in which the specification will go "final":
   http://www.w3.org/2010/soapjms/

I've made some minor changes to the jax-ws and axis2 code to reflect this new binding ID, and I've also run some tests and found a few problems and fixed those as well.    I'm attaching a patch file with the changes.

The purpose of the JIRA is to request that someone apply the changes since I'm not a committer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Assigned: (AXIS2-4855) Support new SOAP/JMS binding ID

Posted by "Jeff Barrett (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Barrett reassigned AXIS2-4855:
-----------------------------------

    Assignee: Jeff Barrett

> Support new SOAP/JMS binding ID
> -------------------------------
>
>                 Key: AXIS2-4855
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4855
>             Project: Axis2
>          Issue Type: Improvement
>          Components: jaxws, kernel
>            Reporter: Phil Adams
>            Assignee: Jeff Barrett
>         Attachments: patch.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The W3C SOAP/JMS binding specification (located here: http://www.w3.org/2002/ws/soapjms/) is nearing its first approved version, and has defined a more up to date binding ID for use in the @BindingType annotation (for JAX-WS endpoint impl classes) and within the soap:binding transport attribute within a WSDL document.    Previously, the SOAP/JMS spec defined this binding ID:
>    http://www.example.org/2006/06/soap/bindings/JMS/
> but that was just a placeholder, and the spec has amended that to this new binding ID:
>    http://www.w3.org/2010/soapjms/
> I've made some minor changes to the jax-ws and axis2 code to reflect this new binding ID, and I've also run some tests and found a few problems and fixed those as well.    I'm attaching a patch file with the changes.
> The purpose of the JIRA is to request that someone apply the changes since I'm not a committer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4855) Support new SOAP/JMS binding ID

Posted by "Jeff Barrett (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929612#action_12929612 ] 

Jeff Barrett commented on AXIS2-4855:
-------------------------------------

Patch from Phil with additional comments and testcase modification by Jeff committed.   Committed revision 1032619

> Support new SOAP/JMS binding ID
> -------------------------------
>
>                 Key: AXIS2-4855
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4855
>             Project: Axis2
>          Issue Type: Improvement
>          Components: jaxws, kernel
>            Reporter: Phil Adams
>            Assignee: Jeff Barrett
>         Attachments: patch.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The W3C SOAP/JMS binding specification (located here: http://www.w3.org/2002/ws/soapjms/) is nearing its first approved version, and has defined a more up to date binding ID for use in the @BindingType annotation (for JAX-WS endpoint impl classes) and within the soap:binding transport attribute within a WSDL document.    Previously, the SOAP/JMS spec defined this binding ID:
>    http://www.example.org/2006/06/soap/bindings/JMS/
> but that was just a placeholder, and the spec has amended that to this new binding ID:
>    http://www.w3.org/2010/soapjms/
> I've made some minor changes to the jax-ws and axis2 code to reflect this new binding ID, and I've also run some tests and found a few problems and fixed those as well.    I'm attaching a patch file with the changes.
> The purpose of the JIRA is to request that someone apply the changes since I'm not a committer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4855) Support new SOAP/JMS binding ID

Posted by "Jeff Barrett (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929611#action_12929611 ] 

Jeff Barrett commented on AXIS2-4855:
-------------------------------------

One other important point.  The issue is with WSDL-less clients and servers.  When WSDL is included, the soap version is determined by the SOAP namespace on the binding.  When WSDL is not included, and the JMS namespace is used on the client (for createDispatch) or on the server (in the @BindingType annotation), that is when the issue occurs.

> Support new SOAP/JMS binding ID
> -------------------------------
>
>                 Key: AXIS2-4855
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4855
>             Project: Axis2
>          Issue Type: Improvement
>          Components: jaxws, kernel
>            Reporter: Phil Adams
>            Assignee: Jeff Barrett
>         Attachments: patch.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The W3C SOAP/JMS binding specification (located here: http://www.w3.org/2002/ws/soapjms/) is nearing its first approved version, and has defined a more up to date binding ID for use in the @BindingType annotation (for JAX-WS endpoint impl classes) and within the soap:binding transport attribute within a WSDL document.    Previously, the SOAP/JMS spec defined this binding ID:
>    http://www.example.org/2006/06/soap/bindings/JMS/
> but that was just a placeholder, and the spec has amended that to this new binding ID:
>    http://www.w3.org/2010/soapjms/
> I've made some minor changes to the jax-ws and axis2 code to reflect this new binding ID, and I've also run some tests and found a few problems and fixed those as well.    I'm attaching a patch file with the changes.
> The purpose of the JIRA is to request that someone apply the changes since I'm not a committer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4855) Support new SOAP/JMS binding ID

Posted by "Jeff Barrett (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929608#action_12929608 ] 

Jeff Barrett commented on AXIS2-4855:
-------------------------------------

This patch uncovered a pre-existing issue in the JAX-WS runtime support of SOAP11 and SOAP12 over JMS, and an associated invalid test.  Since this patch did not introduce the issue, I am going to commit the patch (with a few additional comments describing the issue and disabling the test).  A new Jira will be opened to address the issue.

The issue is in modules/jaxws/src/org/apache/axis2/jaxws/message/Protocol.java and modules/metadata/src/org/apache/axis2/jaxws/description/builder/MDQConstants.java.  The constants for the JMS namepsace for SOAP11 and SOAP12 are the same (per the JMS specification).  MDQConstants defined two constants for SOAP over JMS, one for SOAP11 and one for SOAP12.  Since the constants both used the same namespace (before and after the patch), there was no way to differntiate between SOAP11 and SOAP12 based on those constants.

In Protocol.java, the protocol map registers a protocol (e.g. soap11 or soap12) for each namespace.  Since the key for JMS was the same, the registration for soap11 was overwritten when soap12 was registered.  The test testSOAP12JMSDispatchPayloadMode in /axis2-apache/modules/jaxws-integration/test/org/apache/axis2/jaxws/dispatch/SOAP12DispatchTest.java was validating the bug in Protocol.java, namely the soap12 protocol overwrote the soap11 protocol in the table.

> Support new SOAP/JMS binding ID
> -------------------------------
>
>                 Key: AXIS2-4855
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4855
>             Project: Axis2
>          Issue Type: Improvement
>          Components: jaxws, kernel
>            Reporter: Phil Adams
>            Assignee: Jeff Barrett
>         Attachments: patch.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The W3C SOAP/JMS binding specification (located here: http://www.w3.org/2002/ws/soapjms/) is nearing its first approved version, and has defined a more up to date binding ID for use in the @BindingType annotation (for JAX-WS endpoint impl classes) and within the soap:binding transport attribute within a WSDL document.    Previously, the SOAP/JMS spec defined this binding ID:
>    http://www.example.org/2006/06/soap/bindings/JMS/
> but that was just a placeholder, and the spec has amended that to this new binding ID:
>    http://www.w3.org/2010/soapjms/
> I've made some minor changes to the jax-ws and axis2 code to reflect this new binding ID, and I've also run some tests and found a few problems and fixed those as well.    I'm attaching a patch file with the changes.
> The purpose of the JIRA is to request that someone apply the changes since I'm not a committer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4855) Support new SOAP/JMS binding ID

Posted by "Phil Adams (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Adams updated AXIS2-4855:
------------------------------

    Attachment: patch.txt

Changes to fix this issue.   The changes are based on axis2 revision 1023125.

> Support new SOAP/JMS binding ID
> -------------------------------
>
>                 Key: AXIS2-4855
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4855
>             Project: Axis2
>          Issue Type: Improvement
>          Components: jaxws, kernel
>            Reporter: Phil Adams
>         Attachments: patch.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The W3C SOAP/JMS binding specification (located here: http://www.w3.org/2002/ws/soapjms/) is nearing its first approved version, and has defined a more up to date binding ID for use in the @BindingType annotation (for JAX-WS endpoint impl classes) and within the soap:binding transport attribute within a WSDL document.    Previously, the SOAP/JMS spec defined this binding ID:
>    http://www.example.org/2006/06/soap/bindings/JMS/
> but has amended that to this new binding ID to reflect the year in which the specification will go "final":
>    http://www.w3.org/2010/soapjms/
> I've made some minor changes to the jax-ws and axis2 code to reflect this new binding ID, and I've also run some tests and found a few problems and fixed those as well.    I'm attaching a patch file with the changes.
> The purpose of the JIRA is to request that someone apply the changes since I'm not a committer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4855) Support new SOAP/JMS binding ID

Posted by "Jeff Barrett (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927572#action_12927572 ] 

Jeff Barrett commented on AXIS2-4855:
-------------------------------------

The patch causes a JAX-WS integration test to fail:
Running org.apache.axis2.jaxws.dispatch.SOAP12DispatchTest
Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.969 sec <<< FAILURE!

Results :

Tests in error: 
  testSOAP12JMSDispatchPayloadMode(org.apache.axis2.jaxws.dispatch.SOAP12DispatchTest)

I believe the patch may have uncovered an invalid test.  I am working with Phil on the correct solution.

> Support new SOAP/JMS binding ID
> -------------------------------
>
>                 Key: AXIS2-4855
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4855
>             Project: Axis2
>          Issue Type: Improvement
>          Components: jaxws, kernel
>            Reporter: Phil Adams
>            Assignee: Jeff Barrett
>         Attachments: patch.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The W3C SOAP/JMS binding specification (located here: http://www.w3.org/2002/ws/soapjms/) is nearing its first approved version, and has defined a more up to date binding ID for use in the @BindingType annotation (for JAX-WS endpoint impl classes) and within the soap:binding transport attribute within a WSDL document.    Previously, the SOAP/JMS spec defined this binding ID:
>    http://www.example.org/2006/06/soap/bindings/JMS/
> but that was just a placeholder, and the spec has amended that to this new binding ID:
>    http://www.w3.org/2010/soapjms/
> I've made some minor changes to the jax-ws and axis2 code to reflect this new binding ID, and I've also run some tests and found a few problems and fixed those as well.    I'm attaching a patch file with the changes.
> The purpose of the JIRA is to request that someone apply the changes since I'm not a committer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4855) Support new SOAP/JMS binding ID

Posted by "Phil Adams (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Adams updated AXIS2-4855:
------------------------------

    Description: 
The W3C SOAP/JMS binding specification (located here: http://www.w3.org/2002/ws/soapjms/) is nearing its first approved version, and has defined a more up to date binding ID for use in the @BindingType annotation (for JAX-WS endpoint impl classes) and within the soap:binding transport attribute within a WSDL document.    Previously, the SOAP/JMS spec defined this binding ID:
   http://www.example.org/2006/06/soap/bindings/JMS/
but that was just a placeholder, and the spec has amended that to this new binding ID:
   http://www.w3.org/2010/soapjms/

I've made some minor changes to the jax-ws and axis2 code to reflect this new binding ID, and I've also run some tests and found a few problems and fixed those as well.    I'm attaching a patch file with the changes.

The purpose of the JIRA is to request that someone apply the changes since I'm not a committer.

  was:
The W3C SOAP/JMS binding specification (located here: http://www.w3.org/2002/ws/soapjms/) is nearing its first approved version, and has defined a more up to date binding ID for use in the @BindingType annotation (for JAX-WS endpoint impl classes) and within the soap:binding transport attribute within a WSDL document.    Previously, the SOAP/JMS spec defined this binding ID:
   http://www.example.org/2006/06/soap/bindings/JMS/
but has amended that to this new binding ID to reflect the year in which the specification will go "final":
   http://www.w3.org/2010/soapjms/

I've made some minor changes to the jax-ws and axis2 code to reflect this new binding ID, and I've also run some tests and found a few problems and fixed those as well.    I'm attaching a patch file with the changes.

The purpose of the JIRA is to request that someone apply the changes since I'm not a committer.


> Support new SOAP/JMS binding ID
> -------------------------------
>
>                 Key: AXIS2-4855
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4855
>             Project: Axis2
>          Issue Type: Improvement
>          Components: jaxws, kernel
>            Reporter: Phil Adams
>         Attachments: patch.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The W3C SOAP/JMS binding specification (located here: http://www.w3.org/2002/ws/soapjms/) is nearing its first approved version, and has defined a more up to date binding ID for use in the @BindingType annotation (for JAX-WS endpoint impl classes) and within the soap:binding transport attribute within a WSDL document.    Previously, the SOAP/JMS spec defined this binding ID:
>    http://www.example.org/2006/06/soap/bindings/JMS/
> but that was just a placeholder, and the spec has amended that to this new binding ID:
>    http://www.w3.org/2010/soapjms/
> I've made some minor changes to the jax-ws and axis2 code to reflect this new binding ID, and I've also run some tests and found a few problems and fixed those as well.    I'm attaching a patch file with the changes.
> The purpose of the JIRA is to request that someone apply the changes since I'm not a committer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org