You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/09 08:31:31 UTC
[GitHub] pnowojski commented on a change in pull request #6788:
[FLINK-10469][core] make sure to always write the whole buffer to FileChannel
pnowojski commented on a change in pull request #6788: [FLINK-10469][core] make sure to always write the whole buffer to FileChannel
URL: https://github.com/apache/flink/pull/6788#discussion_r223602597
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/AsynchronousFileIOChannel.java
##########
@@ -28,6 +28,7 @@
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicInteger;
+import static org.apache.flink.util.FileUtils.writeCompletely;
Review comment:
I would slightly lean towards avoiding it as well. But I won't argue about this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services