You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/09/24 12:18:19 UTC
[GitHub] [qpid-broker-j] overmeulen opened a new pull request #60: QPID-8469: [Broker-J][Message Store] The message is already cleaned when the delete listener is called
overmeulen opened a new pull request #60:
URL: https://github.com/apache/qpid-broker-j/pull/60
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] overmeulen commented on pull request #60: QPID-8469: [Broker-J][Message Store] The message is already cleaned when the delete listener is called
Posted by GitBox <gi...@apache.org>.
overmeulen commented on pull request #60:
URL: https://github.com/apache/qpid-broker-j/pull/60#issuecomment-709939584
If I'm not mistaken, this fix has been merged in master, should we close this PR ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] overmeulen commented on pull request #60: QPID-8469: [Broker-J][Message Store] The message is already cleaned when the delete listener is called
Posted by GitBox <gi...@apache.org>.
overmeulen commented on pull request #60:
URL: https://github.com/apache/qpid-broker-j/pull/60#issuecomment-704101354
Thanks Alex,
I added a description in the JIRA ticket.
To make it short, we want to use the delete listener to implement the Claim-Check pattern.
Olivier
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] alex-rufous commented on pull request #60: QPID-8469: [Broker-J][Message Store] The message is already cleaned when the delete listener is called
Posted by GitBox <gi...@apache.org>.
alex-rufous commented on pull request #60:
URL: https://github.com/apache/qpid-broker-j/pull/60#issuecomment-711427883
Hi Olivier,
You are right. The changes have been committed. Please close the PR.
Kind Regards,
Alex
On Fri, 16 Oct 2020 at 10:36, Olivier VERMEULEN <no...@github.com>
wrote:
> If I'm not mistaken, this fix has been merged in master, should we close
> this PR ?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/qpid-broker-j/pull/60#issuecomment-709939584>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AEVFGESTUWTXHMEIWIEHDZ3SLAHYNANCNFSM4RYHKKDA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] alex-rufous commented on pull request #60: QPID-8469: [Broker-J][Message Store] The message is already cleaned when the delete listener is called
Posted by GitBox <gi...@apache.org>.
alex-rufous commented on pull request #60:
URL: https://github.com/apache/qpid-broker-j/pull/60#issuecomment-703953902
Hi Olivier,
Thanks for submitting this pull request.
Though, an invocation of message listener immediately after message removal looks like the right thing to do, could you please expand a bit more on the reasons behind this change? Could you please add a description to the JIRA?
Kind Regards,
Alex
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] overmeulen closed pull request #60: QPID-8469: [Broker-J][Message Store] The message is already cleaned when the delete listener is called
Posted by GitBox <gi...@apache.org>.
overmeulen closed pull request #60:
URL: https://github.com/apache/qpid-broker-j/pull/60
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org