You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/03/18 09:02:01 UTC

[GitHub] [shardingsphere] JiekerTime opened a new pull request #9729: add single tests of db

JiekerTime opened a new pull request #9729:
URL: https://github.com/apache/shardingsphere/pull/9729


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] JiekerTime commented on a change in pull request #9729: add single tests of db

Posted by GitBox <gi...@apache.org>.
JiekerTime commented on a change in pull request #9729:
URL: https://github.com/apache/shardingsphere/pull/9729#discussion_r597415271



##########
File path: shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/cases/dql/dql-integration-test-cases.xml
##########
@@ -510,4 +510,13 @@
     <test-case sql="SELECT * FROM t_user u INNER JOIN t_user_item m ON u.user_id=m.user_id" scenario-types="encrypt,dbtbl_with_read_write_splitting_and_encrypt">
         <assertion expected-data-file="select_join_encrypt.xml"/>
     </test-case>
+
+    <test-case sql="SELECT * FROM t_single_table" db-types="MySQL,Oracle,SQLServer" scenario-types="db">
+        <assertion expected-data-file="select_from_single.xml"/>
+    </test-case>
+
+    <!--fixme! issue #9719-->

Review comment:
       > IMO, you could fix the issue #9719 in this pull request, not adding the comments here to fix.
   
   In fact, many of our cases are annotated in this way. This may make it easier for us to review the problem.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero merged pull request #9729: add single tests of db

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #9729:
URL: https://github.com/apache/shardingsphere/pull/9729


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9729: add single tests of db

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #9729:
URL: https://github.com/apache/shardingsphere/pull/9729#discussion_r597433675



##########
File path: shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/cases/dql/dql-integration-test-cases.xml
##########
@@ -510,4 +510,13 @@
     <test-case sql="SELECT * FROM t_user u INNER JOIN t_user_item m ON u.user_id=m.user_id" scenario-types="encrypt,dbtbl_with_read_write_splitting_and_encrypt">
         <assertion expected-data-file="select_join_encrypt.xml"/>
     </test-case>
+
+    <test-case sql="SELECT * FROM t_single_table" db-types="MySQL,Oracle,SQLServer" scenario-types="db">
+        <assertion expected-data-file="select_from_single.xml"/>
+    </test-case>
+
+    <!--fixme! issue #9719-->

Review comment:
       @SteNicholas , This issue will be handled by @JiekerTime soon and this PR firstly prepare the unit cases.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] SteNicholas commented on a change in pull request #9729: add single tests of db

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #9729:
URL: https://github.com/apache/shardingsphere/pull/9729#discussion_r596903743



##########
File path: shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/cases/dql/dql-integration-test-cases.xml
##########
@@ -510,4 +510,13 @@
     <test-case sql="SELECT * FROM t_user u INNER JOIN t_user_item m ON u.user_id=m.user_id" scenario-types="encrypt,dbtbl_with_read_write_splitting_and_encrypt">
         <assertion expected-data-file="select_join_encrypt.xml"/>
     </test-case>
+
+    <test-case sql="SELECT * FROM t_single_table" db-types="MySQL,Oracle,SQLServer" scenario-types="db">
+        <assertion expected-data-file="select_from_single.xml"/>
+    </test-case>
+
+    <!--fixme! issue #9719-->

Review comment:
       IMO, you could fix the issue #9719 in this pull request, not adding the comments here to fix.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero commented on pull request #9729: add single tests of db

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #9729:
URL: https://github.com/apache/shardingsphere/pull/9729#issuecomment-802524908


   @JiekerTime Generally, LGTM, could you clarify @SteNicholas 's concern?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] SteNicholas commented on a change in pull request #9729: add single tests of db

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #9729:
URL: https://github.com/apache/shardingsphere/pull/9729#discussion_r597422472



##########
File path: shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/cases/dql/dql-integration-test-cases.xml
##########
@@ -510,4 +510,13 @@
     <test-case sql="SELECT * FROM t_user u INNER JOIN t_user_item m ON u.user_id=m.user_id" scenario-types="encrypt,dbtbl_with_read_write_splitting_and_encrypt">
         <assertion expected-data-file="select_join_encrypt.xml"/>
     </test-case>
+
+    <test-case sql="SELECT * FROM t_single_table" db-types="MySQL,Oracle,SQLServer" scenario-types="db">
+        <assertion expected-data-file="select_from_single.xml"/>
+    </test-case>
+
+    <!--fixme! issue #9719-->

Review comment:
       @JiekerTime IMO, it's better to separated into new commit or new PR for this change.
   @tristaZero what do you think about?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9729: add single tests of db

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #9729:
URL: https://github.com/apache/shardingsphere/pull/9729#discussion_r597433675



##########
File path: shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/cases/dql/dql-integration-test-cases.xml
##########
@@ -510,4 +510,13 @@
     <test-case sql="SELECT * FROM t_user u INNER JOIN t_user_item m ON u.user_id=m.user_id" scenario-types="encrypt,dbtbl_with_read_write_splitting_and_encrypt">
         <assertion expected-data-file="select_join_encrypt.xml"/>
     </test-case>
+
+    <test-case sql="SELECT * FROM t_single_table" db-types="MySQL,Oracle,SQLServer" scenario-types="db">
+        <assertion expected-data-file="select_from_single.xml"/>
+    </test-case>
+
+    <!--fixme! issue #9719-->

Review comment:
       @SteNicholas , I get feedback from @JiekerTime .
   This issue will be handled by @JiekerTime soon and this PR firstly prepare the unit cases.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] SteNicholas commented on pull request #9729: add single tests of db

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #9729:
URL: https://github.com/apache/shardingsphere/pull/9729#issuecomment-801957941


   @tristaZero , could you please also help to review this pull request for @JiekerTime ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-io commented on pull request #9729: add single tests of db

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9729:
URL: https://github.com/apache/shardingsphere/pull/9729#issuecomment-801799658


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9729?src=pr&el=h1) Report
   > Merging [#9729](https://codecov.io/gh/apache/shardingsphere/pull/9729?src=pr&el=desc) (bd0fc0a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/8233df336885756b5e1c5a76307ef0b306b1c607?el=desc) (8233df3) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/9729/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/9729?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #9729   +/-   ##
   =========================================
     Coverage     67.43%   67.43%           
     Complexity      685      685           
   =========================================
     Files          1661     1661           
     Lines         27735    27735           
     Branches       4923     4923           
   =========================================
     Hits          18702    18702           
     Misses         7657     7657           
     Partials       1376     1376           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9729?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9729?src=pr&el=footer). Last update [8233df3...bd0fc0a](https://codecov.io/gh/apache/shardingsphere/pull/9729?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org