You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2023/03/22 03:20:08 UTC
[GitHub] [doris] Gabriel39 opened a new pull request, #18014: [Bug](ARRAY) Fix array_product for ARRAY
Gabriel39 opened a new pull request, #18014:
URL: https://github.com/apache/doris/pull/18014
# Proposed changes
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #18014: [Bug](array_product) Fix array_product for ARRAY
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #18014:
URL: https://github.com/apache/doris/pull/18014#issuecomment-1479504279
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.56 seconds
stream load tsv: 475 seconds loaded 74807831229 Bytes, about 150 MB/s
stream load json: 23 seconds loaded 2358488459 Bytes, about 97 MB/s
stream load orc: 74 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230322124134_clickbench_pr_118676.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee merged pull request #18014: [Bug](array_product) Fix array_product for ARRAY
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee merged PR #18014:
URL: https://github.com/apache/doris/pull/18014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18014: [Bug](array_product) Fix array_product for ARRAY
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18014:
URL: https://github.com/apache/doris/pull/18014#issuecomment-1481103715
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #18014: [Bug](array_product) Fix array_product for ARRAY
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #18014:
URL: https://github.com/apache/doris/pull/18014#discussion_r1145576543
##########
be/src/vec/aggregate_functions/aggregate_function_product.h:
##########
@@ -77,6 +77,30 @@ struct AggregateFunctionProductData<Decimal128> {
void reset(Decimal128 value) { product = std::move(value); }
};
+template <>
+struct AggregateFunctionProductData<Decimal128I> {
+ Decimal128I product {};
+
+ template <typename NestedType>
+ void add(Decimal<NestedType> value, UInt32 scale) {
+ product *= value;
+ product /= DataTypeDecimal<Decimal128I>::get_scale_multiplier(scale);
Review Comment:
why directly pass `DataTypeDecimal<Decimal128I>::get_scale_multiplier(scale)` to reduce the function call ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on pull request #18014: [Bug](array_product) Fix array_product for ARRAY
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #18014:
URL: https://github.com/apache/doris/pull/18014#issuecomment-1478868182
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18014: [Bug](array_product) Fix array_product for ARRAY
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #18014:
URL: https://github.com/apache/doris/pull/18014#discussion_r1144191153
##########
be/src/vec/aggregate_functions/aggregate_function_product.h:
##########
@@ -77,6 +77,30 @@ struct AggregateFunctionProductData<Decimal128> {
void reset(Decimal128 value) { product = std::move(value); }
};
+template <>
+struct AggregateFunctionProductData<Decimal128I> {
+ Decimal128I product {};
+
+ template <typename NestedType>
+ void add(Decimal<NestedType> value, UInt32 scale) {
+ product *= value;
+ product /= DataTypeDecimal<Decimal128I>::get_scale_multiplier(scale);
+ }
+
+ void merge(const AggregateFunctionProductData& other, UInt32 scale) {
+ product *= other.product;
+ product /= DataTypeDecimal<Decimal128I>::get_scale_multiplier(scale);
+ }
+
+ void write(BufferWritable& buffer) const { write_binary(product, buffer); }
+
+ void read(BufferReadable& buffer) { read_binary(product, buffer); }
+
+ Decimal128 get() const { return product; }
+
+ void reset(Decimal128 value) { product = std::move(value); }
Review Comment:
warning: std::move of the variable 'value' of the trivially-copyable type 'doris::vectorized::Decimal128' (aka 'Decimal<__int128>') has no effect; remove std::move() [performance-move-const-arg]
```suggestion
void reset(Decimal128 value) { product = value; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on pull request #18014: [Bug](array_product) Fix array_product for ARRAY
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #18014:
URL: https://github.com/apache/doris/pull/18014#issuecomment-1480719927
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on pull request #18014: [Bug](array_product) Fix array_product for ARRAY
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #18014:
URL: https://github.com/apache/doris/pull/18014#issuecomment-1480514044
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18014: [Bug](array_product) Fix array_product for ARRAY
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18014:
URL: https://github.com/apache/doris/pull/18014#issuecomment-1480550043
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18014: [Bug](array_product) Fix array_product for ARRAY
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18014:
URL: https://github.com/apache/doris/pull/18014#issuecomment-1480550061
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org