You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Marcel Reutegger (JIRA)" <ji...@apache.org> on 2019/04/11 14:25:00 UTC

[jira] [Commented] (OAK-8228) Optimize PathUtils.dropIndexFromName(String)

    [ https://issues.apache.org/jira/browse/OAK-8228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815450#comment-16815450 ] 

Marcel Reutegger commented on OAK-8228:
---------------------------------------

Proposed changes are on the GitHub branch: 
https://github.com/apache/jackrabbit-oak/compare/trunk...mreutegg:OAK-8228

The microbenchmark test drops from 200ms for 1M invocations to almost zero.

> Optimize PathUtils.dropIndexFromName(String)
> --------------------------------------------
>
>                 Key: OAK-8228
>                 URL: https://issues.apache.org/jira/browse/OAK-8228
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: commons
>            Reporter: Marcel Reutegger
>            Assignee: Marcel Reutegger
>            Priority: Minor
>             Fix For: 1.14.0
>
>
> The implementation of {{PathUtils.dropIndexFromName(String)}} can easily be optimized for the regular case when the name does not have an index suffix. The current pattern matching taking place every time is rather expensive.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)