You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/07/13 15:43:04 UTC

[GitHub] [hbase] apurtell commented on a diff in pull request #4376: HBASE-26982 Add index and bloom filter statistics of LruBlockCache on…

apurtell commented on code in PR #4376:
URL: https://github.com/apache/hbase/pull/4376#discussion_r920234552


##########
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon:
##########
@@ -348,7 +363,19 @@ are combined counts. Request count is sum of hits and misses.</p>
         <td>Size of DATA Blocks</td>
     </tr>
 </%if> 
-<& evictions_tmpl; bc = bc; &>
+<%if lru %>
+    <tr>
+        <td>Size of Index Blocks</td>
+        <td><% String.format("%,d", ((LruBlockCache)bc).getCurrentIndexSize()) %></td>

Review Comment:
   I think the only improvement that needs be done here is these should also be formatted with TraditionalBinaryPrefix.long2String().



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org