You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by "Jarek Gawor (JIRA)" <ji...@apache.org> on 2010/03/24 16:53:27 UTC

[jira] Created: (ARIES-266) JPA module has dependencies on Application modules

JPA module has dependencies on Application modules
--------------------------------------------------

                 Key: ARIES-266
                 URL: https://issues.apache.org/jira/browse/ARIES-266
             Project: Aries
          Issue Type: Improvement
          Components: Application, JPA
    Affects Versions: 0.1
            Reporter: Jarek Gawor
            Assignee: Jarek Gawor
             Fix For: 0.1


Some of the JPA code uses VersionRange code from the Application module. Since VersionRage is an interface in the application api module, JPA ends up pulling two application bundles: api (for the interface) and utils (for the implementation). 
These dependencies should be completely unnecessary. To break this dependency, the VersionRange class can be moved to the "util" module which JPA already uses.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Created: (ARIES-266) JPA module has dependencies on Application modules

Posted by Jarek Gawor <jg...@gmail.com>.
On Wed, Mar 24, 2010 at 5:30 PM, Alasdair Nottingham <no...@apache.org> wrote:
> Sounds reasonable to me.
>
> I think this is quite a useful class, what do people think about
> proposing it to the OSGi alliance for the next update?

+1. Sounds good to me.

Jarek

Re: [jira] Created: (ARIES-266) JPA module has dependencies on Application modules

Posted by Alasdair Nottingham <no...@apache.org>.
Once we have agreement to propose we just raise a bug in the OSGi  
bugzilla.

Alasdair

On 25 Mar 2010, at 01:40, Lin Sun <li...@gmail.com> wrote:

> I like that idea and agree that it is indeed a very useful class, even
> tho I don't know how to do the proposing part .
>
> Lin
>
> On Wed, Mar 24, 2010 at 4:30 PM, Alasdair Nottingham  
> <no...@apache.org> wrote:
>> Sounds reasonable to me.
>>
>> I think this is quite a useful class, what do people think about
>> proposing it to the OSGi alliance for the next update?
>>
>> Alasdair
>>
>> On 24 March 2010 15:53, Jarek Gawor (JIRA) <ji...@apache.org> wrote:
>>> JPA module has dependencies on Application modules
>>> --------------------------------------------------
>>>
>>>                Key: ARIES-266
>>>                URL: https://issues.apache.org/jira/browse/ARIES-266
>>>            Project: Aries
>>>         Issue Type: Improvement
>>>         Components: Application, JPA
>>>   Affects Versions: 0.1
>>>           Reporter: Jarek Gawor
>>>           Assignee: Jarek Gawor
>>>            Fix For: 0.1
>>>
>>>
>>> Some of the JPA code uses VersionRange code from the Application  
>>> module. Since VersionRage is an interface in the application api  
>>> module, JPA ends up pulling two application bundles: api (for the  
>>> interface) and utils (for the implementation).
>>> These dependencies should be completely unnecessary. To break this  
>>> dependency, the VersionRange class can be moved to the "util"  
>>> module which JPA already uses.
>>>
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>
>>
>>
>> --
>> Alasdair Nottingham
>> not@apache.org
>>

Re: [jira] Created: (ARIES-266) JPA module has dependencies on Application modules

Posted by Lin Sun <li...@gmail.com>.
I like that idea and agree that it is indeed a very useful class, even
tho I don't know how to do the proposing part .

Lin

On Wed, Mar 24, 2010 at 4:30 PM, Alasdair Nottingham <no...@apache.org> wrote:
> Sounds reasonable to me.
>
> I think this is quite a useful class, what do people think about
> proposing it to the OSGi alliance for the next update?
>
> Alasdair
>
> On 24 March 2010 15:53, Jarek Gawor (JIRA) <ji...@apache.org> wrote:
>> JPA module has dependencies on Application modules
>> --------------------------------------------------
>>
>>                 Key: ARIES-266
>>                 URL: https://issues.apache.org/jira/browse/ARIES-266
>>             Project: Aries
>>          Issue Type: Improvement
>>          Components: Application, JPA
>>    Affects Versions: 0.1
>>            Reporter: Jarek Gawor
>>            Assignee: Jarek Gawor
>>             Fix For: 0.1
>>
>>
>> Some of the JPA code uses VersionRange code from the Application module. Since VersionRage is an interface in the application api module, JPA ends up pulling two application bundles: api (for the interface) and utils (for the implementation).
>> These dependencies should be completely unnecessary. To break this dependency, the VersionRange class can be moved to the "util" module which JPA already uses.
>>
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
>
>
> --
> Alasdair Nottingham
> not@apache.org
>

Re: [jira] Created: (ARIES-266) JPA module has dependencies on Application modules

Posted by Alasdair Nottingham <no...@apache.org>.
Sounds reasonable to me.

I think this is quite a useful class, what do people think about
proposing it to the OSGi alliance for the next update?

Alasdair

On 24 March 2010 15:53, Jarek Gawor (JIRA) <ji...@apache.org> wrote:
> JPA module has dependencies on Application modules
> --------------------------------------------------
>
>                 Key: ARIES-266
>                 URL: https://issues.apache.org/jira/browse/ARIES-266
>             Project: Aries
>          Issue Type: Improvement
>          Components: Application, JPA
>    Affects Versions: 0.1
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>             Fix For: 0.1
>
>
> Some of the JPA code uses VersionRange code from the Application module. Since VersionRage is an interface in the application api module, JPA ends up pulling two application bundles: api (for the interface) and utils (for the implementation).
> These dependencies should be completely unnecessary. To break this dependency, the VersionRange class can be moved to the "util" module which JPA already uses.
>
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>



-- 
Alasdair Nottingham
not@apache.org

[jira] Commented: (ARIES-266) JPA module has dependencies on Application modules

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ARIES-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849281#action_12849281 ] 

Jarek Gawor commented on ARIES-266:
-----------------------------------

I copied the VersionRange implementation from application-utils module into util module and updated JPA code to use the util module. Committed in revision 927119.


> JPA module has dependencies on Application modules
> --------------------------------------------------
>
>                 Key: ARIES-266
>                 URL: https://issues.apache.org/jira/browse/ARIES-266
>             Project: Aries
>          Issue Type: Improvement
>          Components: Application, JPA
>    Affects Versions: 0.1
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>             Fix For: 0.1
>
>
> Some of the JPA code uses VersionRange code from the Application module. Since VersionRage is an interface in the application api module, JPA ends up pulling two application bundles: api (for the interface) and utils (for the implementation). 
> These dependencies should be completely unnecessary. To break this dependency, the VersionRange class can be moved to the "util" module which JPA already uses.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ARIES-266) JPA module has dependencies on Application modules

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ARIES-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849309#action_12849309 ] 

Jarek Gawor commented on ARIES-266:
-----------------------------------

I also reimplemented the Application's VersionRange interface using VersionRange class from the util module. Committed in revision 927127. This was done in order to keep existing code working and to reduce code duplication. 
In the future we might want to consider removing the Application's VersionRange interface and just using the VersionRange class from the util module.


> JPA module has dependencies on Application modules
> --------------------------------------------------
>
>                 Key: ARIES-266
>                 URL: https://issues.apache.org/jira/browse/ARIES-266
>             Project: Aries
>          Issue Type: Improvement
>          Components: Application, JPA
>    Affects Versions: 0.1
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>             Fix For: 0.1
>
>
> Some of the JPA code uses VersionRange code from the Application module. Since VersionRage is an interface in the application api module, JPA ends up pulling two application bundles: api (for the interface) and utils (for the implementation). 
> These dependencies should be completely unnecessary. To break this dependency, the VersionRange class can be moved to the "util" module which JPA already uses.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (ARIES-266) JPA module has dependencies on Application modules

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ARIES-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor resolved ARIES-266.
-------------------------------

    Resolution: Fixed

> JPA module has dependencies on Application modules
> --------------------------------------------------
>
>                 Key: ARIES-266
>                 URL: https://issues.apache.org/jira/browse/ARIES-266
>             Project: Aries
>          Issue Type: Improvement
>          Components: Application, JPA
>    Affects Versions: 0.1
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>             Fix For: 0.1
>
>
> Some of the JPA code uses VersionRange code from the Application module. Since VersionRage is an interface in the application api module, JPA ends up pulling two application bundles: api (for the interface) and utils (for the implementation). 
> These dependencies should be completely unnecessary. To break this dependency, the VersionRange class can be moved to the "util" module which JPA already uses.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.