You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/12/20 05:24:17 UTC
[GitHub] [hudi] zhangyue19921010 opened a new pull request #4398: [Minor] Add rerunFailingTestsCount for failed testes
zhangyue19921010 opened a new pull request #4398:
URL: https://github.com/apache/hudi/pull/4398
## What is the purpose of the pull request
it looks like the UT test `testLatestCheckpointCarryOverWithMultipleWriters ` in `UT FT clients & cli & utilities & sync/hive-sync` is also a little bit unstable recently.
```
[ERROR] HoodieTableType).[1] COPY_ON_WRITE(testLatestCheckpointCarryOverWithMultipleWriters Time elapsed: 7.455 s <<< ERROR!
```
Such as
```
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=4287&view=logs&j=b1544eb9-7ff1-5db9-0187-3e05abf459bc&t=0ec7e803-cfc6-5180-f2a9-ea971f54ee54
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=4291&view=logs&j=b1544eb9-7ff1-5db9-0187-3e05abf459bc&t=0ec7e803-cfc6-5180-f2a9-ea971f54ee54
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=4287&view=logs&j=b1544eb9-7ff1-5db9-0187-3e05abf459bc&t=0ec7e803-cfc6-5180-f2a9-ea971f54ee54
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=4284&view=logs&j=b1544eb9-7ff1-5db9-0187-3e05abf459bc&t=0ec7e803-cfc6-5180-f2a9-ea971f54ee54
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=4283&view=logs&j=b1544eb9-7ff1-5db9-0187-3e05abf459bc&t=0ec7e803-cfc6-5180-f2a9-ea971f54ee54
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=4281&view=logs&j=b1544eb9-7ff1-5db9-0187-3e05abf459bc&t=0ec7e803-cfc6-5180-f2a9-ea971f54ee54
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=4279&view=logs&j=b1544eb9-7ff1-5db9-0187-3e05abf459bc&t=0ec7e803-cfc6-5180-f2a9-ea971f54ee54
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=4300&view=logs&j=b1544eb9-7ff1-5db9-0187-3e05abf459bc&t=0ec7e803-cfc6-5180-f2a9-ea971f54ee54
```
.... etc...
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997705459
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585",
"triggerID" : "5207ad831bb51e2450d0193304fd06845de8c164",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4588",
"triggerID" : "997704632",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5207ad831bb51e2450d0193304fd06845de8c164 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4588)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 edited a comment on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 edited a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-998363844
Hi @yihua and @nsivabalan
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=4580&view=results

As we can see, I set `timeoutInMinutes: 90 (as int)` for job 4 and it works fine based on https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema%2Cparameter-schema
and job2 is timeout for compartment.
```
jobs:
- deployment: string # name of the deployment job, A-Z, a-z, 0-9, and underscore. The word "deploy" is a keyword and is unsupported as the deployment name.
displayName: string # friendly name to display in the UI
pool: # see pool schema
name: string # Use only global level variables for defining a pool name. Stage/job level variables are not supported to define pool name.
demands: string | [ string ]
workspace:
clean: outputs | resources | all # what to clean up before the job runs
dependsOn: string
condition: string
continueOnError: boolean # 'true' if future jobs should run even if this job fails; defaults to 'false'
container: containerReference # container to run this job inside
services: { string: string | container } # container resources to run as a service container
timeoutInMinutes: nonEmptyString # how long to run the job before automatically cancelling
cancelTimeoutInMinutes: nonEmptyString # how much time to give 'run always even if cancelled tasks' before killing them
variables: # several syntaxes, see specific section
environment: string # target environment name and optionally a resource name to record the deployment history; format: <environment-name>.<resource-name>
strategy:
runOnce: #rolling, canary are the other strategies that are supported
deploy:
steps: [ script | bash | pwsh | powershell | checkout | task | templateReference ]
```
I will rerun this 4 jobs to see it works as expected, when set `timeoutInMinutes: '90' as string`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 edited a comment on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 edited a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-998363844
Hi @yihua and @nsivabalan
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=4580&view=results

As we can see, I set `timeoutInMinutes: 90 (as int)` for job 4 and it works fine based on
1. https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema%2Cparameter-schema
2. https://docs.microsoft.com/en-us/azure/devops/pipelines/process/phases?view=azure-devops&tabs=yaml#timeouts
and job2 is timeout for compartment.
```
jobs:
- deployment: string # name of the deployment job, A-Z, a-z, 0-9, and underscore. The word "deploy" is a keyword and is unsupported as the deployment name.
displayName: string # friendly name to display in the UI
pool: # see pool schema
name: string # Use only global level variables for defining a pool name. Stage/job level variables are not supported to define pool name.
demands: string | [ string ]
workspace:
clean: outputs | resources | all # what to clean up before the job runs
dependsOn: string
condition: string
continueOnError: boolean # 'true' if future jobs should run even if this job fails; defaults to 'false'
container: containerReference # container to run this job inside
services: { string: string | container } # container resources to run as a service container
timeoutInMinutes: nonEmptyString # how long to run the job before automatically cancelling
cancelTimeoutInMinutes: nonEmptyString # how much time to give 'run always even if cancelled tasks' before killing them
variables: # several syntaxes, see specific section
environment: string # target environment name and optionally a resource name to record the deployment history; format: <environment-name>.<resource-name>
strategy:
runOnce: #rolling, canary are the other strategies that are supported
deploy:
steps: [ script | bash | pwsh | powershell | checkout | task | templateReference ]
The timeoutInMinutes allows a limit to be set for the job execution time. When not specified, the default is 60 minutes. When 0 is specified, the maximum limit is used (described above).
```
I will rerun these 4 jobs to see it works as expected, when set `timeoutInMinutes: '90' as string`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 edited a comment on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 edited a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-998363844
Hi @yihua and @nsivabalan
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=4580&view=results

As we can see, I set `timeoutInMinutes: 90 (as int)` for job 4 and it works fine based on https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema%2Cparameter-schema
and job2 is timeout for compartment.
```
jobs:
- deployment: string # name of the deployment job, A-Z, a-z, 0-9, and underscore. The word "deploy" is a keyword and is unsupported as the deployment name.
displayName: string # friendly name to display in the UI
pool: # see pool schema
name: string # Use only global level variables for defining a pool name. Stage/job level variables are not supported to define pool name.
demands: string | [ string ]
workspace:
clean: outputs | resources | all # what to clean up before the job runs
dependsOn: string
condition: string
continueOnError: boolean # 'true' if future jobs should run even if this job fails; defaults to 'false'
container: containerReference # container to run this job inside
services: { string: string | container } # container resources to run as a service container
timeoutInMinutes: nonEmptyString # how long to run the job before automatically cancelling
cancelTimeoutInMinutes: nonEmptyString # how much time to give 'run always even if cancelled tasks' before killing them
variables: # several syntaxes, see specific section
environment: string # target environment name and optionally a resource name to record the deployment history; format: <environment-name>.<resource-name>
strategy:
runOnce: #rolling, canary are the other strategies that are supported
deploy:
steps: [ script | bash | pwsh | powershell | checkout | task | templateReference ]
```
I will rerun these 4 jobs to see it works as expected, when set `timeoutInMinutes: '90' as string`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 edited a comment on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 edited a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-998400775
> I have landed a patch on this end #4407
Okay, now we only need to pay attention to `rerunFailingTestsCount `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4398: [Minor] Add rerunFailingTestsCount for failed testes
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997703049
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585",
"triggerID" : "5207ad831bb51e2450d0193304fd06845de8c164",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5207ad831bb51e2450d0193304fd06845de8c164 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-998394899
I have landed a patch on this end https://github.com/apache/hudi/pull/4407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 edited a comment on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 edited a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-998363844
Hi @yihua and @nsivabalan
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=4580&view=results

As we can see, I set `timeoutInMinutes: 90 (as int)` for job 4 and it works fine based on https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema%2Cparameter-schema
and job2 is timeout for compartment.
```
jobs:
- deployment: string # name of the deployment job, A-Z, a-z, 0-9, and underscore. The word "deploy" is a keyword and is unsupported as the deployment name.
displayName: string # friendly name to display in the UI
pool: # see pool schema
name: string # Use only global level variables for defining a pool name. Stage/job level variables are not supported to define pool name.
demands: string | [ string ]
workspace:
clean: outputs | resources | all # what to clean up before the job runs
dependsOn: string
condition: string
continueOnError: boolean # 'true' if future jobs should run even if this job fails; defaults to 'false'
container: containerReference # container to run this job inside
services: { string: string | container } # container resources to run as a service container
timeoutInMinutes: nonEmptyString # how long to run the job before automatically cancelling
cancelTimeoutInMinutes: nonEmptyString # how much time to give 'run always even if cancelled tasks' before killing them
variables: # several syntaxes, see specific section
environment: string # target environment name and optionally a resource name to record the deployment history; format: <environment-name>.<resource-name>
strategy:
runOnce: #rolling, canary are the other strategies that are supported
deploy:
steps: [ script | bash | pwsh | powershell | checkout | task | templateReference ]
The timeoutInMinutes allows a limit to be set for the job execution time. When not specified, the default is 60 minutes. When 0 is specified, the maximum limit is used (described above).
```
I will rerun these 4 jobs to see it works as expected, when set `timeoutInMinutes: '90' as string`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4398: [Minor] Add rerunFailingTestsCount for failed testes
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997657263
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7427a651670cacf1498d778580bad08833139f20 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4398: [Minor] Add rerunFailingTestsCount for failed testes
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997608743
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7427a651670cacf1498d778580bad08833139f20 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997778041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585",
"triggerID" : "5207ad831bb51e2450d0193304fd06845de8c164",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4588",
"triggerID" : "997704632",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5207ad831bb51e2450d0193304fd06845de8c164 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4588)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 edited a comment on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 edited a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997741824
cc @nsivabalan @xushiyan and @yihua
Sorry to bother you guys. Would you mind to take a look?
Really appreciate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4398: [Minor] Add rerunFailingTestsCount for failed testes
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997668489
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5207ad831bb51e2450d0193304fd06845de8c164",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7427a651670cacf1498d778580bad08833139f20 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580)
* 5207ad831bb51e2450d0193304fd06845de8c164 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997778041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585",
"triggerID" : "5207ad831bb51e2450d0193304fd06845de8c164",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4588",
"triggerID" : "997704632",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5207ad831bb51e2450d0193304fd06845de8c164 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4588)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 commented on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-998400775
> I have landed a patch on this end #4407
Okay, Now we only need to pay attention to `rerunFailingTestsCount `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 edited a comment on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 edited a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997704325

Flak test rerun and success as `RUN 2: PASS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4398: [Minor] Add rerunFailingTestsCount for failed testes
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997669959
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585",
"triggerID" : "5207ad831bb51e2450d0193304fd06845de8c164",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7427a651670cacf1498d778580bad08833139f20 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580)
* 5207ad831bb51e2450d0193304fd06845de8c164 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 commented on pull request #4398: [Minor] Add rerunFailingTestsCount for failed testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997704632
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 commented on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-998363844
Hi @yihua and @nsivabalan

As we can see, I set `timeoutInMinutes: 90` for job 4 and it works fine based on https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema%2Cparameter-schema
```
jobs:
- deployment: string # name of the deployment job, A-Z, a-z, 0-9, and underscore. The word "deploy" is a keyword and is unsupported as the deployment name.
displayName: string # friendly name to display in the UI
pool: # see pool schema
name: string # Use only global level variables for defining a pool name. Stage/job level variables are not supported to define pool name.
demands: string | [ string ]
workspace:
clean: outputs | resources | all # what to clean up before the job runs
dependsOn: string
condition: string
continueOnError: boolean # 'true' if future jobs should run even if this job fails; defaults to 'false'
container: containerReference # container to run this job inside
services: { string: string | container } # container resources to run as a service container
timeoutInMinutes: nonEmptyString # how long to run the job before automatically cancelling
cancelTimeoutInMinutes: nonEmptyString # how much time to give 'run always even if cancelled tasks' before killing them
variables: # several syntaxes, see specific section
environment: string # target environment name and optionally a resource name to record the deployment history; format: <environment-name>.<resource-name>
strategy:
runOnce: #rolling, canary are the other strategies that are supported
deploy:
steps: [ script | bash | pwsh | powershell | checkout | task | templateReference ]
```
I will rerun this 4 jobs to see it works as expected, when set `timeoutInMinutes: '90' as string`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 edited a comment on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 edited a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-998363844
Hi @yihua and @nsivabalan
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=4580&view=results

As we can see, I set `timeoutInMinutes: 90 (as int)` for job 4 and it works fine based on
1. https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema%2Cparameter-schema
2. https://docs.microsoft.com/en-us/azure/devops/pipelines/process/phases?view=azure-devops&tabs=yaml#timeouts
and job2 is timeout for compartment.
```
jobs:
- deployment: string # name of the deployment job, A-Z, a-z, 0-9, and underscore. The word "deploy" is a keyword and is unsupported as the deployment name.
displayName: string # friendly name to display in the UI
pool: # see pool schema
name: string # Use only global level variables for defining a pool name. Stage/job level variables are not supported to define pool name.
demands: string | [ string ]
workspace:
clean: outputs | resources | all # what to clean up before the job runs
dependsOn: string
condition: string
continueOnError: boolean # 'true' if future jobs should run even if this job fails; defaults to 'false'
container: containerReference # container to run this job inside
services: { string: string | container } # container resources to run as a service container
timeoutInMinutes: nonEmptyString # how long to run the job before automatically cancelling
cancelTimeoutInMinutes: nonEmptyString # how much time to give 'run always even if cancelled tasks' before killing them
variables: # several syntaxes, see specific section
environment: string # target environment name and optionally a resource name to record the deployment history; format: <environment-name>.<resource-name>
strategy:
runOnce: #rolling, canary are the other strategies that are supported
deploy:
steps: [ script | bash | pwsh | powershell | checkout | task | templateReference ]
The timeoutInMinutes allows a limit to be set for the job execution time. When not specified, the default is 60 minutes. When 0 is specified, the maximum limit is used (described above).
```
I will rerun these 4 jobs to see it works as expected, when set `timeoutInMinutes: '90' as string`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 commented on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-998400344
Hi @yihua and @nsivabalan

As this shows, Job2 didn't be canceled after 1 hour.
Also as mentioned before, the retry config also works. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4398: [Minor] Add rerunFailingTestsCount for failed testes
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997668489
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5207ad831bb51e2450d0193304fd06845de8c164",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7427a651670cacf1498d778580bad08833139f20 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580)
* 5207ad831bb51e2450d0193304fd06845de8c164 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-998364667
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585",
"triggerID" : "5207ad831bb51e2450d0193304fd06845de8c164",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4588",
"triggerID" : "997704632",
"triggerType" : "MANUAL"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4614",
"triggerID" : "998363949",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5207ad831bb51e2450d0193304fd06845de8c164 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4588) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4614)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4398: [Minor] Add rerunFailingTestsCount for failed testes
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997608743
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7427a651670cacf1498d778580bad08833139f20 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 commented on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-998363949
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 commented on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997741824
cc @nsivabalan @xushiyan
Sorry to bother you guys. Would you mind to take a look?
Really appreciate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4398: [Minor] Add rerunFailingTestsCount for failed testes
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997609837
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7427a651670cacf1498d778580bad08833139f20 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 commented on a change in pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on a change in pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#discussion_r772799301
##########
File path: pom.xml
##########
@@ -355,6 +342,20 @@
<pluginManagement>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>${maven-surefire-plugin.version}</version>
+ <configuration>
+ <rerunFailingTestsCount>3</rerunFailingTestsCount>
Review comment:
Mentioned here https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html
```
(JUnit 4+ providers and JUnit 5+ providers since 3.0.0-M4) The number of times each failing test will be rerun. If set larger than 0, rerun failing tests immediately after they fail. If a failing test passes in any of those reruns, it will be marked as pass and reported as a "flake". However, all the failing attempts will be recorded.
Default value is: 0.
User property is: surefire.rerunFailingTestsCount.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4398: [Minor] Add rerunFailingTestsCount for failed testes
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997657263
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7427a651670cacf1498d778580bad08833139f20 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan merged pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
xushiyan merged pull request #4398:
URL: https://github.com/apache/hudi/pull/4398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4398: [Minor] Add rerunFailingTestsCount for failed testes
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997703049
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585",
"triggerID" : "5207ad831bb51e2450d0193304fd06845de8c164",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5207ad831bb51e2450d0193304fd06845de8c164 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 commented on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997779058

For now each stage will take almost 1 hour to finish work. We may need to expand the timeout time(60 minutes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4398: [Minor] Add rerunFailingTestsCount for failed testes
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997609837
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7427a651670cacf1498d778580bad08833139f20 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 edited a comment on pull request #4398: [Minor] Add rerunFailingTestsCount for failed testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 edited a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997704325

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-998399537
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585",
"triggerID" : "5207ad831bb51e2450d0193304fd06845de8c164",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4588",
"triggerID" : "997704632",
"triggerType" : "MANUAL"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4614",
"triggerID" : "998363949",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5207ad831bb51e2450d0193304fd06845de8c164 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4588) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4614)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 commented on a change in pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on a change in pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#discussion_r772801240
##########
File path: pom.xml
##########
@@ -316,19 +316,6 @@
</execution>
</executions>
</plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-surefire-plugin</artifactId>
- <version>${maven-surefire-plugin.version}</version>
- <configuration>
- <argLine>@{argLine}</argLine>
- <systemPropertyVariables>
- <log4j.configuration>
- ${surefire-log4j.file}
- </log4j.configuration>
- </systemPropertyVariables>
- </configuration>
- </plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
Review comment:
Emmm, I'm not sure about the scope of failsafe plugin.
Also this pr is try to fix flaky testes and expand timeout time.
Should we take care of it here or maybe be we can step another PR to deal with failsafe :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 edited a comment on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 edited a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-998363844
Hi @yihua and @nsivabalan
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=4580&view=results

As we can see, I set `timeoutInMinutes: 90` for job 4 and it works fine based on https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema%2Cparameter-schema
and job2 is timeout for compartment.
```
jobs:
- deployment: string # name of the deployment job, A-Z, a-z, 0-9, and underscore. The word "deploy" is a keyword and is unsupported as the deployment name.
displayName: string # friendly name to display in the UI
pool: # see pool schema
name: string # Use only global level variables for defining a pool name. Stage/job level variables are not supported to define pool name.
demands: string | [ string ]
workspace:
clean: outputs | resources | all # what to clean up before the job runs
dependsOn: string
condition: string
continueOnError: boolean # 'true' if future jobs should run even if this job fails; defaults to 'false'
container: containerReference # container to run this job inside
services: { string: string | container } # container resources to run as a service container
timeoutInMinutes: nonEmptyString # how long to run the job before automatically cancelling
cancelTimeoutInMinutes: nonEmptyString # how much time to give 'run always even if cancelled tasks' before killing them
variables: # several syntaxes, see specific section
environment: string # target environment name and optionally a resource name to record the deployment history; format: <environment-name>.<resource-name>
strategy:
runOnce: #rolling, canary are the other strategies that are supported
deploy:
steps: [ script | bash | pwsh | powershell | checkout | task | templateReference ]
```
I will rerun this 4 jobs to see it works as expected, when set `timeoutInMinutes: '90' as string`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-998368619
cool, thanks for the tip. We have been struggling w/ timeouts of late. good to know about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#discussion_r772796740
##########
File path: pom.xml
##########
@@ -316,19 +316,6 @@
</execution>
</executions>
</plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-surefire-plugin</artifactId>
- <version>${maven-surefire-plugin.version}</version>
- <configuration>
- <argLine>@{argLine}</argLine>
- <systemPropertyVariables>
- <log4j.configuration>
- ${surefire-log4j.file}
- </log4j.configuration>
- </systemPropertyVariables>
- </configuration>
- </plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
Review comment:
does it also make sense to move failsafe to plugin management too?
##########
File path: pom.xml
##########
@@ -355,6 +342,20 @@
<pluginManagement>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>${maven-surefire-plugin.version}</version>
+ <configuration>
+ <rerunFailingTestsCount>3</rerunFailingTestsCount>
Review comment:
unfortunately the website says only for junit 4.x
https://maven.apache.org/surefire/maven-surefire-plugin/examples/rerun-failing-tests.html
have you tried it and seen it working?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4398: [Minor] Add rerunFailingTestsCount for failed testes
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997669959
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585",
"triggerID" : "5207ad831bb51e2450d0193304fd06845de8c164",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7427a651670cacf1498d778580bad08833139f20 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580)
* 5207ad831bb51e2450d0193304fd06845de8c164 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
yihua commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-998356889
@zhangyue19921010 Have you checked if 90-minute timeout is actually effective, i.e., the CI tests run more than an hour without being killed? Not sure if Azure CI allows the timeout to be more than an hour in effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 commented on a change in pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on a change in pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#discussion_r772798742
##########
File path: pom.xml
##########
@@ -355,6 +342,20 @@
<pluginManagement>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>${maven-surefire-plugin.version}</version>
+ <configuration>
+ <rerunFailingTestsCount>3</rerunFailingTestsCount>
Review comment:
Sure thing, it is supported in 3.0.0-M4

It works fine as `RUN 1 failed` and `RUN 2 PASS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4398: [Minor] Add rerunFailingTestsCount for failed testes
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997705459
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585",
"triggerID" : "5207ad831bb51e2450d0193304fd06845de8c164",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4588",
"triggerID" : "997704632",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5207ad831bb51e2450d0193304fd06845de8c164 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4588)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 commented on pull request #4398: [Minor] Add rerunFailingTestsCount for failed testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-997704325
<img width="1089" alt="截屏2021-12-20 下午4 26 45" src="https://user-images.githubusercontent.com/69956021/146736379-26147c44-2113-4e61-9dba-092f77efb959.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 edited a comment on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 edited a comment on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-998363844
Hi @yihua and @nsivabalan
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=4580&view=results

As we can see, I set `timeoutInMinutes: 90` for job 4 and it works fine based on https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema%2Cparameter-schema
```
jobs:
- deployment: string # name of the deployment job, A-Z, a-z, 0-9, and underscore. The word "deploy" is a keyword and is unsupported as the deployment name.
displayName: string # friendly name to display in the UI
pool: # see pool schema
name: string # Use only global level variables for defining a pool name. Stage/job level variables are not supported to define pool name.
demands: string | [ string ]
workspace:
clean: outputs | resources | all # what to clean up before the job runs
dependsOn: string
condition: string
continueOnError: boolean # 'true' if future jobs should run even if this job fails; defaults to 'false'
container: containerReference # container to run this job inside
services: { string: string | container } # container resources to run as a service container
timeoutInMinutes: nonEmptyString # how long to run the job before automatically cancelling
cancelTimeoutInMinutes: nonEmptyString # how much time to give 'run always even if cancelled tasks' before killing them
variables: # several syntaxes, see specific section
environment: string # target environment name and optionally a resource name to record the deployment history; format: <environment-name>.<resource-name>
strategy:
runOnce: #rolling, canary are the other strategies that are supported
deploy:
steps: [ script | bash | pwsh | powershell | checkout | task | templateReference ]
```
I will rerun this 4 jobs to see it works as expected, when set `timeoutInMinutes: '90' as string`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#issuecomment-998364667
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7427a651670cacf1498d778580bad08833139f20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4580",
"triggerID" : "7427a651670cacf1498d778580bad08833139f20",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585",
"triggerID" : "5207ad831bb51e2450d0193304fd06845de8c164",
"triggerType" : "PUSH"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4588",
"triggerID" : "997704632",
"triggerType" : "MANUAL"
}, {
"hash" : "5207ad831bb51e2450d0193304fd06845de8c164",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4614",
"triggerID" : "998363949",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5207ad831bb51e2450d0193304fd06845de8c164 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4585) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4588) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4614)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #4398: [HUDI-3070] Add rerunFailingTestsCount for flakly testes
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#discussion_r772811735
##########
File path: pom.xml
##########
@@ -355,6 +342,20 @@
<pluginManagement>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>${maven-surefire-plugin.version}</version>
+ <configuration>
+ <rerunFailingTestsCount>3</rerunFailingTestsCount>
Review comment:
cool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org