You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "wwelling (via GitHub)" <gi...@apache.org> on 2024/04/03 15:19:14 UTC
[PR] Use hostContext property for RewriteHandler rules [solr]
wwelling opened a new pull request, #2388:
URL: https://github.com/apache/solr/pull/2388
https://issues.apache.org/jira/browse/SOLR-XXXXX
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Please provide a short description of the changes you're making with this pull request.
# Solution
Please provide a short description of the approach taken to implement your solution.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Use hostContext property for RewriteHandler rules [solr]
Posted by "wwelling (via GitHub)" <gi...@apache.org>.
wwelling commented on PR #2388:
URL: https://github.com/apache/solr/pull/2388#issuecomment-2038265317
@dsmiley, thanks. I'll look into additional Jetty routing. Do think it is a reasonable request of the [Solr Docker](https://hub.docker.com/_/solr) image to afford environment driven context path configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Use hostContext property for RewriteHandler rules [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2388:
URL: https://github.com/apache/solr/pull/2388#issuecomment-2035531253
IIRC it was actually not well supported in recent versions of Solr, it may even not have worked at all in the 8x line... With the V2 api's starting to live under `/api`, we want to make `/solr` and `/api` fixed paths. I don't recall why, but this did faciliate the v2 api stuff... Maybe @gerlowskija can shed osme light.
@wwelling I'd love to hear the use cases that you would *want* this for.. make sure we haven't shut the door on some reasons..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Use hostContext property for RewriteHandler rules [solr]
Posted by "wwelling (via GitHub)" <gi...@apache.org>.
wwelling commented on PR #2388:
URL: https://github.com/apache/solr/pull/2388#issuecomment-2042852384
@dsmiley thanks. We will give that a try. Would be easy enough to mount a file for additional routing. Will have to see if it supports system variable or environment variable substitution. Otherwise, the context path configuration will still not be [12-factor](https://12factor.net/config).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Use hostContext property for RewriteHandler rules [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #2388:
URL: https://github.com/apache/solr/pull/2388#issuecomment-2042927447
I think aliasing /solr would be simpler than inserting a root. And while I wasn't supportive of aliasing... if it can be done simply in jetty.xml and toggled off then why not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Use hostContext property for RewriteHandler rules [solr]
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on PR #2388:
URL: https://github.com/apache/solr/pull/2388#issuecomment-2034928189
I believe we recently removed the ability to specify a new hostContext in `main`. @epugh @gerlowskija
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Use hostContext property for RewriteHandler rules [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2388:
URL: https://github.com/apache/solr/pull/2388#issuecomment-2042870864
I chatted a bit with @gerlowskija about this ticket, and I think he was supportive of the idea of being able to insert a root hostcontext that would go between `http://myserver:8983` and the `/solr` or `/api` end points.. So you could have `http://myserver:8983/DEV/solr` and `http://myserver:8983/DEV/api` configuration. So that might be a path you would want to explore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Use hostContext property for RewriteHandler rules [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh closed pull request #2388: Use hostContext property for RewriteHandler rules
URL: https://github.com/apache/solr/pull/2388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Use hostContext property for RewriteHandler rules [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #2388:
URL: https://github.com/apache/solr/pull/2388#issuecomment-2037652388
@wwelling You can configure Solr's Jetty to map `/foo` to `/solr` if that would help.
I think the overall objective was to reduce internal code maintenance on an option that didn't seem worth supporting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Use hostContext property for RewriteHandler rules [solr]
Posted by "wwelling (via GitHub)" <gi...@apache.org>.
wwelling commented on PR #2388:
URL: https://github.com/apache/solr/pull/2388#issuecomment-2037401821
Hi @epugh, our use case is through a constraint from load balancing requiring matching path with application context path. We have a solution with an additional application sidecar proxy but would like to be able to configure Solr's Jetty servlet container.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Use hostContext property for RewriteHandler rules [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2388:
URL: https://github.com/apache/solr/pull/2388#issuecomment-2043326665
@wwelling based on the conversation above, I am going to close this PR. If you decide to move forward with the nesting of both `/solr` and `/api` as a new feature, please open a JIRA, and I'd be happy to review your PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Use hostContext property for RewriteHandler rules [solr]
Posted by "wwelling (via GitHub)" <gi...@apache.org>.
wwelling commented on PR #2388:
URL: https://github.com/apache/solr/pull/2388#issuecomment-2035026777
@HoustonPutman thanks for the quick reply. I have been reading about that in the Jira and previous issues/PRs.
I noticed `hostContext` is still used in [solr-jetty-context.xml](https://github.com/apache/solr/blob/main/solr/server/contexts/solr-jetty-context.xml#L4).
To you by chance now why Solr is removing ability to configure its context path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Use hostContext property for RewriteHandler rules [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #2388:
URL: https://github.com/apache/solr/pull/2388#issuecomment-2038656809
ehhh, no I don't TBH. At least it's somewhat easy to create a new server/etc/jetty-customAdditions.xml and it'll be loaded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Use hostContext property for RewriteHandler rules [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #2388:
URL: https://github.com/apache/solr/pull/2388#issuecomment-2042929556
My concern is avoiding complexity 99+% of users don't need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org