[GitHub] [apisix-docker] tokers commented on a change in pull request #133: CI: add apisix-docker test

[GitBox <gi...@apache.org>]

tokers commented on a change in pull request #133:
URL: https://github.com/apache/apisix-docker/pull/133#discussion_r579102745



##########
File path: .github/workflows/apisix-alpine-docker-test.yaml
##########
@@ -0,0 +1,35 @@
+name: apisix Alpine docker Test

Review comment:
       Use `APISIX` instead of `apisix` in title.

##########
File path: example/docker-compose.yml
##########
@@ -2,7 +2,7 @@ version: "3"
 
 services:
   apisix:
-    image: apache/apisix:2.3-alpine
+    image: apache/apisix:2.3-centos

Review comment:
       What's the purpose of this change?

##########
File path: .github/workflows/apisix-alpine-docker-test.yaml
##########
@@ -0,0 +1,35 @@
+name: apisix Alpine docker Test
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    services:
+      etcd:
+        image: bitnami/etcd:3.4.13
+        ports:
+          - 2379:2379
+          - 2380:2380
+        env:
+          ALLOW_NONE_AUTHENTICATION: yes
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Build and Test
+        run: |
+          docker build -t apisix:alpine -f ./alpine/Dockerfile .
+          docker run -v `pwd`/all-in-one/apisix/config.yaml:/usr/local/apisix/conf/config.yaml -p 9080:9080 -d apisix:alpine
+          sleep 30
+          curl http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1'

Review comment:
       Why calling curl twice?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org