You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "AntoinePrv (via GitHub)" <gi...@apache.org> on 2026/09/04 12:51:45 UTC
[PR] Add dlpack producer to FixedShapeTensorArray/Scalar [arrow]
AntoinePrv opened a new pull request, #51159:
URL: https://github.com/apache/arrow/pull/51159
### Rationale for this change
Have the same coverage as `to_numpy`.
### What changes are included in this PR?
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Additions only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38868: [Python] Add dlpack producer to FixedShapeTensorArray/Scalar [arrow]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #51159:
URL: https://github.com/apache/arrow/pull/51159#discussion_r3934157687
##########
python/pyarrow/array.pxi:
##########
@@ -2269,7 +2269,7 @@ cdef class Array(_PandasConvertible):
return pyarrow_wrap_array(array)
- def __dlpack__(self, stream=None, max_version=None, dl_device=None, copy=None):
+ def __dlpack__(self, *, stream=None, max_version=None, dl_device=None, copy=None):
Review Comment:
Changing Array.__dlpack__ to keyword-only (adding `*`) is a backward-incompatible Python API change for callers that may have been passing positional arguments. If the intent is spec conformance, consider a deprecation path; otherwise keep the previous signature to preserve compatibility.
##########
python/pyarrow/scalar.pxi:
##########
@@ -1586,6 +1586,35 @@ cdef class FixedShapeTensorScalar(ExtensionScalar):
ctensor = GetResultValue(c_type.MakeTensor(scalar))
return pyarrow_wrap_tensor(ctensor)
+ def __dlpack__(self, *, stream=None, max_version=None, dl_device=None, copy=None):
+ """
+ Export a tensor array as a DLPack capsule.
+
+ See :meth:`Tensor.__dlpack__` for the parameter semantics.
+ """
Review Comment:
The new FixedShapeTensorScalar.__dlpack__ docstring says it exports a "tensor array"; this is a scalar method, so the wording is misleading for API docs/users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38868: [Python] Add dlpack producer to FixedShapeTensorArray/Scalar [arrow]
Posted by "AntoinePrv (via GitHub)" <gi...@apache.org>.
AntoinePrv commented on PR #51159:
URL: https://github.com/apache/arrow/pull/51159#issuecomment-5541291918
@AlenkaF @rok @pitrou this one is ready too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38868: [Python] Add dlpack producer to FixedShapeTensorArray/Scalar [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #51159:
URL: https://github.com/apache/arrow/pull/51159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add dlpack producer to FixedShapeTensorArray/Scalar [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51159:
URL: https://github.com/apache/arrow/pull/51159#issuecomment-5540695898
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
**This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format.**
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
**After updating the title, you can mark the pull request as ready for review.**
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org