You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/11 03:56:05 UTC
[GitHub] [flink] walterddr commented on a change in pull request #7702:
[FLINK-11088][Security][YARN] Allow YARN to discover pre-installed keytab
files
walterddr commented on a change in pull request #7702: [FLINK-11088][Security][YARN] Allow YARN to discover pre-installed keytab files
URL: https://github.com/apache/flink/pull/7702#discussion_r390733239
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnConfigKeys.java
##########
@@ -36,7 +36,10 @@
public static final String FLINK_JAR_PATH = "_FLINK_JAR_PATH"; // the Flink jar resource location (in HDFS).
public static final String FLINK_YARN_FILES = "_FLINK_YARN_FILES"; // the root directory for all yarn application files
+ @Deprecated
public static final String KEYTAB_PATH = "_KEYTAB_PATH";
+ public static final String REMOTE_KEYTAB_PATH = "_REMOTE_KEYTAB_PATH";
Review comment:
This is a good catch (to also response to other comment --> technically speaking there should only be one ConfigKey in the JM/TM perspective: the "REMOTE_KEYTAB_PATH", or previously known as "KEYTAB_PATH".
I would revert the changes I've done here. since if the keytab is shipped over as you mentioned, it doesn't matter whether it is originated from a remote ship location or pre-installed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services