You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/13 11:16:03 UTC
[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request, #9013: [Enhancement] [Storage Vectorize] optimize BitmapRangeIterator.next_range()
BiteTheDDDDt opened a new pull request, #9013:
URL: https://github.com/apache/incubator-doris/pull/9013
# Proposed changes
Issue Number: close #9012
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a diff in pull request #9013: [Enhancement] [Storage Vectorize] optimize BitmapRangeIterator.next_range()
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #9013:
URL: https://github.com/apache/incubator-doris/pull/9013#discussion_r849424570
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -57,23 +57,38 @@ class SegmentIterator::BitmapRangeIterator {
// read next range into [*from, *to) whose size <= max_range_size.
// return false when there is no more range.
- bool next_range(uint32_t max_range_size, uint32_t* from, uint32_t* to) {
+ bool next_range(const uint32_t max_range_size, uint32_t* from, uint32_t* to) {
if (_eof) {
return false;
}
+
*from = _buf[_buf_pos];
- uint32_t range_size = 0, last_val;
- do {
- last_val = _buf[_buf_pos];
- _buf_pos++;
- range_size++;
- if (UNLIKELY(_buf_pos == _buf_size)) { // read next batch
- _read_next_batch();
- if (_eof) {
- break;
- }
- }
- } while (range_size < max_range_size && _buf[_buf_pos] == last_val + 1);
+ uint32_t range_size = 0;
+ uint32_t last_val = _buf[_buf_pos] - 1; // this initial value just make first batch valid
Review Comment:
> is it posible that `_buf[_buf_pos] == 0`?
`ffffffff+1=0` , it is ok, but I think change it to x=y-1 is better, I will change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9013: [Enhancement] [Storage Vectorize] optimize BitmapRangeIterator.next_range()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9013:
URL: https://github.com/apache/incubator-doris/pull/9013#issuecomment-1098794699
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9013: [Enhancement] [Storage Vectorize] optimize BitmapRangeIterator.next_range()
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9013:
URL: https://github.com/apache/incubator-doris/pull/9013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #9013: [Enhancement] [Storage Vectorize] optimize BitmapRangeIterator.next_range()
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #9013:
URL: https://github.com/apache/incubator-doris/pull/9013#discussion_r849419196
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -57,23 +57,38 @@ class SegmentIterator::BitmapRangeIterator {
// read next range into [*from, *to) whose size <= max_range_size.
// return false when there is no more range.
- bool next_range(uint32_t max_range_size, uint32_t* from, uint32_t* to) {
+ bool next_range(const uint32_t max_range_size, uint32_t* from, uint32_t* to) {
if (_eof) {
return false;
}
+
*from = _buf[_buf_pos];
- uint32_t range_size = 0, last_val;
- do {
- last_val = _buf[_buf_pos];
- _buf_pos++;
- range_size++;
- if (UNLIKELY(_buf_pos == _buf_size)) { // read next batch
- _read_next_batch();
- if (_eof) {
- break;
- }
- }
- } while (range_size < max_range_size && _buf[_buf_pos] == last_val + 1);
+ uint32_t range_size = 0;
+ uint32_t last_val = _buf[_buf_pos] - 1; // this initial value just make first batch valid
Review Comment:
is it posible that `_buf[_buf_pos] == 0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9013: [Enhancement] [Storage Vectorize] optimize BitmapRangeIterator.next_range()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9013:
URL: https://github.com/apache/incubator-doris/pull/9013#issuecomment-1098794728
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org