[GitHub] [couchdb] big-r81 commented on a diff in pull request #4680: [shard splitting] allow resumption of failed jobs & make timeout configurable

["big-r81 (via GitHub)" <gi...@apache.org>]

big-r81 commented on code in PR #4680:
URL: https://github.com/apache/couchdb/pull/4680#discussion_r1268029994


##########
src/mem3/src/mem3_rep.erl:
##########
@@ -90,14 +93,20 @@ go(#shard{} = Source, #{} = Targets0, Opts) when map_size(Targets0) > 0 ->
                 "incomplete_ranges",
                 false
             ),
+            RexiTimeout =
+                case proplists:get_value(rexi_timeout, Opts) of
+                    T when is_integer(T) -> T;

Review Comment:
   Do we want an additional guard T > 0 ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org