[jira] [Commented] (MAHOUT-2012) Hard Coded Block in Canopy Cluster (Samsara)

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAHOUT-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154313#comment-16154313 ] 

ASF GitHub Bot commented on MAHOUT-2012:
----------------------------------------

GitHub user rawkintrevo opened a pull request:

    https://github.com/apache/mahout/pull/337

    MAHOUT-2012 Fix hardcoded dataset in Canopy Cluster

    ### Purpose of PR:
    Please give a short description of what this PR is for.
    
    
    ### Important ToDos
    Please mark each with an "x"
    - [x] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
    - [x] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.
    - [x] Created unit tests where appropriate
    - [x] Added licenses correct on newly added files
    - [x] Assigned JIRA to self
    - [x] Added documentation in scala docs/java docs, and to website
    - [x] Successfully built and ran all unit tests, verified that all tests pass locally.
    
    If all of these things aren't complete, but you still feel it is
    appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the
    descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"
    
    Does this change break earlier versions?
    
    Is this the beginning of a larger project for which a feature branch should be made?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rawkintrevo/mahout mahout-2012

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/mahout/pull/337.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #337
    
----
commit 87ed74163a4870ae3fb297ed87c5d93343cdf042
Author: Trevor a.k.a @rawkintrevo <tr...@gmail.com>
Date:   2017-09-05T21:08:27Z

    MAHOUT-2012 Fix hardcoded dataset in Canopy Cluster

----


> Hard Coded Block in Canopy Cluster (Samsara)
> --------------------------------------------
>
>                 Key: MAHOUT-2012
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-2012
>             Project: Mahout
>          Issue Type: Bug
>          Components: Algorithms
>    Affects Versions: 0.13.0, 0.13.1
>            Reporter: Trevor Grant
>            Assignee: Trevor Grant
>
> The same dataset which is used in the tests is hard coded in the Canopy function
> https://github.com/apache/mahout/blob/master/math-scala/src/main/scala/org/apache/mahout/math/algorithms/clustering/Canopy.scala#L131
> However renders algorithm useless.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)